LGTM, but see below for alternatives I'd like to explore.
https://codereview.appspot.com/11311043/diff/1/tests/com/google/caja/plugin/WebDriverHandle.java
File tests/com/google/caja/plugin/WebDriverHandle.java (right):
https://codereview.appspot.com/11311043/diff/1/tests/com/google/caja/plugin/WebDriverHandle.java#newcode130
tests/com/google/caja/plugin/WebDriverHandle.java:130:
driver.get("about:blank");
Two thoughts:
1. Why do we need to visit about:blank at all, rather than going
directly to the next test page? If we don't, wouldn't that fix the hang?
2. Can we make BROWSER_REUSE the default if running under Firefox rather
than Chrome? In particular, Firefox will start up in safe mode if the
option key is held down, even if it's not foreground, which breaks
testing and so is problematic if you're trying to do something else
while the tests are running.
https://codereview.appspot.com/11311043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
