https://codereview.appspot.com/11311043/diff/1/tests/com/google/caja/plugin/WebDriverHandle.java
File tests/com/google/caja/plugin/WebDriverHandle.java (right):
https://codereview.appspot.com/11311043/diff/1/tests/com/google/caja/plugin/WebDriverHandle.java#newcode130
tests/com/google/caja/plugin/WebDriverHandle.java:130:
driver.get("about:blank");
On 2013/07/16 16:54:54, kpreid2 wrote:
Two thoughts:
1. Why do we need to visit about:blank at all, rather than going
directly to the
next test page? If we don't, wouldn't that fix the hang?
iirc, taking out the nav to about:blank didn't fix the problem, but I
didn't really keep careful notes at the time, so I might be remembering
wrong. It takes like an hour or so of continual testing to check if the
flakiness is still there, and since I had no idea why it was flaky I was
stabbing randomly in the dark. now that I have some better idea, I'll
attack it more systematically, next time I look at it.
2. Can we make BROWSER_REUSE the default if running under Firefox
rather than
Chrome? In particular, Firefox will start up in safe mode if the
option key is
held down, even if it's not foreground, which breaks testing and so is
problematic if you're trying to do something else while the tests are
running.
hm, that seems like not the right fix since even with BROWSER_REUSE true
it will start a new firefox at unpredictable times. I'll think about it.
https://codereview.appspot.com/11311043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
