https://codereview.appspot.com/11291043/diff/3001/tests/com/google/caja/plugin/generic-host-page.html
File tests/com/google/caja/plugin/generic-host-page.html (right):
https://codereview.appspot.com/11291043/diff/3001/tests/com/google/caja/plugin/generic-host-page.html#newcode119
tests/com/google/caja/plugin/generic-host-page.html:119: .api({
On 2013/07/16 19:49:18, kpreid_google wrote:
The point of this page is to provide an _unmodified_ Caja environment.
I can see
the use of this, but you should make it opt-in — just add another
checkbox to
the form.
(We also ought to have a single standard implementation of "just pass
on
alert()", but ...)
(Now, the _right_ solution for debuggability is to provide 'console'
by default,
but that's more work.)
Done.
https://codereview.appspot.com/11291043/diff/3001/tests/com/google/caja/plugin/third-party-tests.json
File tests/com/google/caja/plugin/third-party-tests.json (right):
https://codereview.appspot.com/11291043/diff/3001/tests/com/google/caja/plugin/third-party-tests.json#newcode6
tests/com/google/caja/plugin/third-party-tests.json:6: "guest-template":
"/third_party/js/jqueryjs/test/index.html?dev=true&module=*",
On 2013/07/16 19:49:18, kpreid_google wrote:
What does dev=true do?
Use un-minified jQuery files.
https://codereview.appspot.com/11291043/diff/3001/tests/com/google/caja/plugin/third-party-tests.json#newcode13
tests/com/google/caja/plugin/third-party-tests.json:13:
"https://code.google.com/p/google-caja/issues/detail?id=1199";,
On 2013/07/16 19:49:18, kpreid_google wrote:
Links are good. Just links, not so good. This doesn't help the reader
figure out
whether the failure they're seeing is known.
I don't want to add redundant hand-curated info, so maybe we can make
the renderer render the bug synopsis or something, but for the JSON,
just links is necessary and sufficient.
https://codereview.appspot.com/11291043/diff/3001/tests/com/google/caja/plugin/third-party-tests.json#newcode57
tests/com/google/caja/plugin/third-party-tests.json:57: "comment": [
On 2013/07/16 19:49:18, kpreid_google wrote:
delete this
Done.
https://codereview.appspot.com/11291043/diff/3001/tests/com/google/caja/plugin/third-party-tests.json#newcode87
tests/com/google/caja/plugin/third-party-tests.json:87:
"TODO(ihab.awad): Amidst this file with diagnosis and bug filing"
On 2013/07/16 19:49:18, kpreid_google wrote:
That's a bit cryptic in case someone else is picking up the work.
Done.
https://codereview.appspot.com/11291043/diff/3001/third_party/js/jqueryjs/test/unit/attributes.js
File third_party/js/jqueryjs/test/unit/attributes.js (right):
https://codereview.appspot.com/11291043/diff/3001/third_party/js/jqueryjs/test/unit/attributes.js#newcode82
third_party/js/jqueryjs/test/unit/attributes.js:82: // TODO(ihab.awad):
'target' attributes are rewritten in Caja.
On 2013/07/16 19:49:18, kpreid_google wrote:
My practice has been to label modifications "Patched for Caja" so we
can
uniformly grep and forward-port them. If you want to use other labels,
please
add documentation of them to jqueryjs/README-Caja.txt.
(Actually, that file doesn't even mention "Patched for Caja". I see I
confused
it with third_party/js/proxies/README-Caja which has a similar role.
Please add
suitable text to the one for jQuery.)
And unless you're planning to fix the visibility of attribute
rewriting, I don't
see that this is a TODO.
tab indent lines in this file for consistency
Done.
https://codereview.appspot.com/11291043/diff/3001/third_party/js/jqueryjs/test/unit/attributes.js#newcode157
third_party/js/jqueryjs/test/unit/attributes.js:157: // TODO(ihab.awad):
'onclick' JavaScript attributes are rewritten in Caja.
On 2013/07/16 19:49:18, kpreid_google wrote:
tab indent
Done.
https://codereview.appspot.com/11291043/diff/3001/third_party/js/jqueryjs/test/unit/attributes.js#newcode350
third_party/js/jqueryjs/test/unit/attributes.js:350: // TODO(ihab.awad):
Setting 'autofocus' property throws, so we need to add the
On 2013/07/16 19:49:18, kpreid_google wrote:
That was fixed in r5483.
Done.
https://codereview.appspot.com/11291043/diff/3001/third_party/js/jqueryjs/test/unit/attributes.js#newcode375
third_party/js/jqueryjs/test/unit/attributes.js:375: // TODO(ihab.awad):
document.createAttrbute() is nonexistent, so we need to
On 2013/07/16 19:49:18, kpreid_google wrote:
typo: createAttribute (also occurs below)
Done.
https://codereview.appspot.com/11291043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
