https://codereview.appspot.com/11291043/diff/3001/tests/com/google/caja/plugin/third-party-tests.json
File tests/com/google/caja/plugin/third-party-tests.json (right):
https://codereview.appspot.com/11291043/diff/3001/tests/com/google/caja/plugin/third-party-tests.json#newcode6
tests/com/google/caja/plugin/third-party-tests.json:6: "guest-template":
"/third_party/js/jqueryjs/test/index.html?dev=true&module=*",
On 2013/07/22 20:20:21, ihab.awad wrote:
On 2013/07/16 19:49:18, kpreid_google wrote:
> What does dev=true do?
Use un-minified jQuery files.
Instead of hardcoding it here, have qunit-test-driver.js read the
minified= URL param and insert it there (make sure it works the same way
for jQuery UI). That way, automated tests (ant runtpt) still test
against the minified files.
https://codereview.appspot.com/11291043/diff/3001/third_party/js/jqueryjs/test/unit/attributes.js
File third_party/js/jqueryjs/test/unit/attributes.js (right):
https://codereview.appspot.com/11291043/diff/3001/third_party/js/jqueryjs/test/unit/attributes.js#newcode82
third_party/js/jqueryjs/test/unit/attributes.js:82: // TODO(ihab.awad):
'target' attributes are rewritten in Caja.
On 2013/07/22 20:20:21, ihab.awad wrote:
On 2013/07/16 19:49:18, kpreid_google wrote:
> My practice has been to label modifications "Patched for Caja" so
> we can uniformly grep and forward-port them. If you want to use
> other labels, please add documentation of them to
> jqueryjs/README-Caja.txt.
>
> (Actually, that file doesn't even mention "Patched for Caja". I see
I
> confused it with third_party/js/proxies/README-Caja which has
> a similar role. Please add suitable text to the one for jQuery.)
[...]
Done.
Not done? I see no changes to README-Caja.
https://codereview.appspot.com/11291043/diff/10001/tests/com/google/caja/plugin/generic-host-page.html
File tests/com/google/caja/plugin/generic-host-page.html (right):
https://codereview.appspot.com/11291043/diff/10001/tests/com/google/caja/plugin/generic-host-page.html#newcode81
tests/com/google/caja/plugin/generic-host-page.html:81: <label><input
type="checkbox" name="alert" value="true"> Provide
<code>alert</code></label>
long line — existing line was long, but both should be fixed. Suggest
breaking between ">" and "Provide".
https://codereview.appspot.com/11291043/diff/10001/third_party/js/jqueryjs/test/unit/event.js
File third_party/js/jqueryjs/test/unit/event.js (right):
https://codereview.appspot.com/11291043/diff/10001/third_party/js/jqueryjs/test/unit/event.js#newcode1849
third_party/js/jqueryjs/test/unit/event.js:1849: test('ihab got up to
here', function() {
"Patched for Caja" somewhere in here
https://codereview.appspot.com/11291043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
