LGTM
https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/lang/css/css3-defs.json
File src/com/google/caja/lang/css/css3-defs.json (right):
https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/lang/css/css3-defs.json#newcode5
src/com/google/caja/lang/css/css3-defs.json:5: "This differs from the
spec in that it has ranges on some numeric values.",
long line
https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):
https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/plugin/domado.js#newcode1076
src/com/google/caja/plugin/domado.js:1076: // TODO(kpreid): Review
whether this has unnecessary features (as we're
I believe the answer to this question is "no", and you can delete this
comment.
https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/plugin/domado.js#newcode1087
src/com/google/caja/plugin/domado.js:1087: if (cssName === 'float') {
domName = 'cssFloat'; }
I'd reorder/combine the above two statements because the computed
domName is immediately discarded.
https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/plugin/domado.js#newcode1093
src/com/google/caja/plugin/domado.js:1093: isDomName: function (p) {
Thanks for less confusing names.
https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/plugin/domado.js#newcode1099
src/com/google/caja/plugin/domado.js:1099: dom2css: function (p) {
I'd prefer domToCss or maybe even domToCssName.
https://codereview.appspot.com/13060045/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
