updated snapshot

https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/lang/css/css3-defs.json
File src/com/google/caja/lang/css/css3-defs.json (right):

https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/lang/css/css3-defs.json#newcode5
src/com/google/caja/lang/css/css3-defs.json:5: "This differs from the
spec in that it has ranges on some numeric values.",
On 2013/08/22 20:55:27, kpreid2 wrote:
long line

Done.

https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):

https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/plugin/domado.js#newcode1076
src/com/google/caja/plugin/domado.js:1076: // TODO(kpreid): Review
whether this has unnecessary features (as we're
On 2013/08/22 20:55:27, kpreid2 wrote:
I believe the answer to this question is "no", and you can delete this
comment.

Done.

https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/plugin/domado.js#newcode1087
src/com/google/caja/plugin/domado.js:1087: if (cssName === 'float') {
domName = 'cssFloat'; }
On 2013/08/22 20:55:27, kpreid2 wrote:
I'd reorder/combine the above two statements because the computed
domName is
immediately discarded.

Done.

https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/plugin/domado.js#newcode1099
src/com/google/caja/plugin/domado.js:1099: dom2css: function (p) {
On 2013/08/22 20:55:27, kpreid2 wrote:
I'd prefer domToCss or maybe even domToCssName.

Done.

https://codereview.appspot.com/13060045/

--

--- You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to