Reviewers: MarkM,
Description:
Previously, ses.ok('not a valid name') was treated as equivalent to
ses.ok(), which is dangerous if, for example, the maxAcceptableSeverity
is set high and the intent of the ses.ok(...) call was to make a choice
based on meeting a lower severity (as caja.js does). Now, passing an
unknown severity name will throw an error.Fixes <https://code.google.com/p/google-caja/issues/detail?id=1758>. Supporting changes: * browser-test-case.html no longer requires an es5= parameter, but will fail if anything which would depend on it is called while it is unspecified. This allows it to be used for tests that do not use caja.js at all, such as this new test for SES. * Tweaked ses-tests.json catalog to use inheritance/grouping. * Note: severityNameToLevel was misnamed and entirely unused. Please review this at https://codereview.appspot.com/13694048/ Affected files (+108, -70 lines): M src/com/google/caja/ses/repairES5.js M tests/com/google/caja/plugin/browser-test-case.js M tests/com/google/caja/ses/ses-tests.json A tests/com/google/caja/ses/test-ses-parts.js ----- You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
