The King is dead, long live the King! On Thu, Oct 3, 2013 at 1:42 PM, <[email protected]> wrote: > Reviewers: ihab.awad, felix8a, > > Description: > * Remove ES5/3 mode from caja.js (the es5Mode parameter remains but > may not be set to false), es53-taming-frame, et cetera. > * Remove mode support from browser test framework. > * Remove browser tests which pertain only to ES5/3 mode and remove > mode conditionals from tests. > * Add files test-mitigating-url-rewriter-replacement.js and > test-mitigating-url-rewriter-input.js to disentangle > test-mitigating-url-rewriter.js from deleted test-precajole.js. > * Remove proxy test suite from third_party, since we are no longer > _implementing_ proxies. > > > There are many things yet to remove which are NOT removed by this > change, including: > > * Remove the actual cajoler and ES5/3 rewriter from the server code. > * Remove the 'rulebreaker' facility in Domado. > * Remove references to es53 mode in the Playground. > * Remove precajoling. > * Simplify Domado event handler attribute handling now that eval is > never unavailable. > * Remove, if not needed for some reason, the USELESS object from > the taming membrane. > > Please review this at https://codereview.appspot.com/14347044/ > > Affected files (+368, -9887 lines): > M build.xml > D src/com/google/caja/cajita-promise.js > M src/com/google/caja/demos/capman/js/pacman.js > M src/com/google/caja/demos/playground/client/ui/PlaygroundView.java > M src/com/google/caja/demos/trycaja/js/trycaja.js > M src/com/google/caja/plugin/caja.js > D src/com/google/caja/plugin/cajoling-service-client.js > D src/com/google/caja/plugin/capture-cajoled-module.js > D src/com/google/caja/plugin/capture-domado.js > D src/com/google/caja/plugin/capture-taming-membrane.js > D src/com/google/caja/plugin/capture-taming-schema.js > M src/com/google/caja/plugin/domado.js > D src/com/google/caja/plugin/es53-frame-group.js > M src/com/google/caja/plugin/guest-manager.js > D src/com/google/caja/plugin/json-rest-transport.js > D src/com/google/caja/plugin/load-module.js > M src/com/google/caja/plugin/ses-frame-group.js > M src/com/google/caja/plugin/taming-membrane.js > D src/com/google/caja/triv-logger.js > M tests/com/google/caja/apitaming/tests-cajoled.js > M tests/com/google/caja/apitaming/tests-index.js > M tests/com/google/caja/apitaming/tests-side-by-side.html > M tests/com/google/caja/apitaming/tests-side-by-side.js > M tests/com/google/caja/plugin/BrowserTestCase.java > D tests/com/google/caja/plugin/HtmlCompiledPluginTest.java > M tests/com/google/caja/plugin/MainBrowserTest.java > D tests/com/google/caja/plugin/ModulesBrowserTest.java > M tests/com/google/caja/plugin/apidiff/analyzer.html > M tests/com/google/caja/plugin/apitaming-tests.json > M tests/com/google/caja/plugin/browser-test-case.js > M tests/com/google/caja/plugin/browser-tests.json > M tests/com/google/caja/plugin/cajajs-bare-test.html > M tests/com/google/caja/plugin/catalog-parser.js > D tests/com/google/caja/plugin/container.js > M tests/com/google/caja/plugin/generic-host-page.html > D tests/com/google/caja/plugin/load-module-test.js > M tests/com/google/caja/plugin/meta-test.js > D tests/com/google/caja/plugin/modules-test-isolate.html > D tests/com/google/caja/plugin/modules-test.html > D tests/com/google/caja/plugin/test-assert-es53mode.js > D tests/com/google/caja/plugin/test-assert-es5mode.js > D tests/com/google/caja/plugin/test-automode1.js > D tests/com/google/caja/plugin/test-automode2.js > D tests/com/google/caja/plugin/test-automode3.js > D tests/com/google/caja/plugin/test-automode4.js > M tests/com/google/caja/plugin/test-cajajs-invocation.js > D > tests/com/google/caja/plugin/test-cajajs-minor-version-skew-cajoled-module.js > D > tests/com/google/caja/plugin/test-cajajs-minor-version-skew-cajoler-response.js > M tests/com/google/caja/plugin/test-cajajs-never-starts.js > D > tests/com/google/caja/plugin/test-cajajs-version-skew-cajoled-module.js > D > tests/com/google/caja/plugin/test-cajajs-version-skew-cajoler-response.js > M tests/com/google/caja/plugin/test-cajajs-version-skew-js-files.js > M tests/com/google/caja/plugin/test-client-uri-rewriting.js > D tests/com/google/caja/plugin/test-compare-modes.js > M tests/com/google/caja/plugin/test-container-overflow.js > D tests/com/google/caja/plugin/test-custom-cajoling-service-client.js > M tests/com/google/caja/plugin/test-domado-dom-guest.html > M tests/com/google/caja/plugin/test-domado-events-guest.html > M tests/com/google/caja/plugin/test-domado-forms-guest.html > M tests/com/google/caja/plugin/test-domado-global.js > M tests/com/google/caja/plugin/test-domado-iframe-guest.html > M tests/com/google/caja/plugin/test-domado-special-guest.html > M tests/com/google/caja/plugin/test-domado-special.js > M tests/com/google/caja/plugin/test-external-script-guest.html > M tests/com/google/caja/plugin/test-index.html > M tests/com/google/caja/plugin/test-inline-script.html > M tests/com/google/caja/plugin/test-language-guest.html > A tests/com/google/caja/plugin/test-mitigating-url-rewriter-input.js > A > tests/com/google/caja/plugin/test-mitigating-url-rewriter-replacement.js > M tests/com/google/caja/plugin/test-mitigating-url-rewriter.js > D tests/com/google/caja/plugin/test-precajole-guest.html > D tests/com/google/caja/plugin/test-precajole-precajoled.js > D tests/com/google/caja/plugin/test-precajole.js > D tests/com/google/caja/plugin/test-proxies.js > M tests/com/google/caja/plugin/test-scan-core.js > M tests/com/google/caja/plugin/test-scan-guest.js > D tests/com/google/caja/plugin/test-taming-primitives.js > M tests/com/google/caja/plugin/test-taming-tamed-guest.html > M tests/com/google/caja/plugin/test-taming-tamed.js > M tests/com/google/caja/plugin/test-taming-untamed-guest.html > M tests/com/google/caja/plugin/test-taming-untamed.js > M tests/com/google/caja/plugin/test-target-attribute-presets.js > M tests/com/google/caja/plugin/test-unicode.js > M tests/com/google/caja/plugin/third-party-tests.json > M tests/com/google/caja/ses/ses-tests.json > M tests/com/google/caja/testParserSpeed.js > D third_party/js/proxies/README > D third_party/js/proxies/README-Caja > D third_party/js/proxies/TestCases/callfix.js > D third_party/js/proxies/TestCases/coerce-propertydescriptors.js > D third_party/js/proxies/TestCases/construct-primitive.js > D third_party/js/proxies/TestCases/constructor.js > D third_party/js/proxies/TestCases/create.js > D third_party/js/proxies/TestCases/createFunction.js > D third_party/js/proxies/TestCases/default-construct.js > D third_party/js/proxies/TestCases/defaultProto.js > D third_party/js/proxies/TestCases/defineProperty-attributes.js > D third_party/js/proxies/TestCases/delegatedAccessor.js > D third_party/js/proxies/TestCases/denyfix.js > D third_party/js/proxies/TestCases/derivedset.js > D third_party/js/proxies/TestCases/doublelifting/defineProperty.js > D third_party/js/proxies/TestCases/doublelifting/delete.js > D third_party/js/proxies/TestCases/doublelifting/enumerate-nonempty.js > D third_party/js/proxies/TestCases/doublelifting/enumerate.js > D third_party/js/proxies/TestCases/doublelifting/fix.js > D third_party/js/proxies/TestCases/doublelifting/get.js > D > third_party/js/proxies/TestCases/doublelifting/getOwnPropertyDescriptor.js > D > third_party/js/proxies/TestCases/doublelifting/getOwnPropertyNames.js > D > third_party/js/proxies/TestCases/doublelifting/getPropertyDescriptor.js > D third_party/js/proxies/TestCases/doublelifting/has.js > D third_party/js/proxies/TestCases/doublelifting/hasOwn.js > D third_party/js/proxies/TestCases/doublelifting/keys.js > D third_party/js/proxies/TestCases/doublelifting/set.js > D third_party/js/proxies/TestCases/doublelifting/util.js > D third_party/js/proxies/TestCases/duplicate-getOwnPropertyNames.js > D third_party/js/proxies/TestCases/duplicate-keys.js > D third_party/js/proxies/TestCases/enum-add.js > D third_party/js/proxies/TestCases/enum-delete.js > D third_party/js/proxies/TestCases/enum-fix.js > D third_party/js/proxies/TestCases/enum-mutate.js > D third_party/js/proxies/TestCases/enumeration.js > D third_party/js/proxies/TestCases/fixidentity.js > D third_party/js/proxies/TestCases/functionproxies.js > D third_party/js/proxies/TestCases/handlersharing.js > D third_party/js/proxies/TestCases/handlerthis.js > D third_party/js/proxies/TestCases/illegalargs.js > D third_party/js/proxies/TestCases/instanceof.js > D third_party/js/proxies/TestCases/invoke.js > D third_party/js/proxies/TestCases/invokeDelegator.js > D third_party/js/proxies/TestCases/meta-throw.js > D third_party/js/proxies/TestCases/missing-derivedtraps.js > D third_party/js/proxies/TestCases/missing-fundamentaltraps.js > D third_party/js/proxies/TestCases/missingargs.js > D third_party/js/proxies/TestCases/noconstructor.js > D third_party/js/proxies/TestCases/nonconfigurable.js > D third_party/js/proxies/TestCases/objectproxies.js > D third_party/js/proxies/TestCases/propertynames.js > D third_party/js/proxies/TestCases/proxytypes.js > D third_party/js/proxies/TestCases/recursive-fix.js > D third_party/js/proxies/TestCases/returned-propertydescriptors.js > D third_party/js/proxies/TestCases/sink.js > D third_party/js/proxies/TestCases/stratification.js > D third_party/js/proxies/TestCases/tostringarray/enumerate.js > D > third_party/js/proxies/TestCases/tostringarray/getOwnPropertyNames.js > D third_party/js/proxies/TestCases/tostringarray/keys.js > D third_party/js/proxies/TestCases/trap-arguments/defineProperty.js > D third_party/js/proxies/TestCases/trap-arguments/delete.js > D > third_party/js/proxies/TestCases/trap-arguments/enumerate-nonempty.js > D third_party/js/proxies/TestCases/trap-arguments/enumerate.js > D third_party/js/proxies/TestCases/trap-arguments/fix.js > D third_party/js/proxies/TestCases/trap-arguments/get.js > D > third_party/js/proxies/TestCases/trap-arguments/getOwnPropertyDescriptor.js > D > third_party/js/proxies/TestCases/trap-arguments/getOwnPropertyNames.js > D > third_party/js/proxies/TestCases/trap-arguments/getPropertyDescriptor.js > D third_party/js/proxies/TestCases/trap-arguments/has.js > D third_party/js/proxies/TestCases/trap-arguments/hasOwn.js > D third_party/js/proxies/TestCases/trap-arguments/keys.js > D third_party/js/proxies/TestCases/trap-arguments/set.js > D third_party/js/proxies/TestCases/trap-arguments/util.js > D third_party/js/proxies/TestCases/trap-throws/defineProperty.js > D third_party/js/proxies/TestCases/trap-throws/delete.js > D third_party/js/proxies/TestCases/trap-throws/enumerate.js > D third_party/js/proxies/TestCases/trap-throws/fix.js > D third_party/js/proxies/TestCases/trap-throws/get.js > D > third_party/js/proxies/TestCases/trap-throws/getOwnPropertyDescriptor.js > D third_party/js/proxies/TestCases/trap-throws/getOwnPropertyNames.js > D > third_party/js/proxies/TestCases/trap-throws/getPropertyDescriptor.js > D third_party/js/proxies/TestCases/trap-throws/has.js > D third_party/js/proxies/TestCases/trap-throws/hasOwn.js > D third_party/js/proxies/TestCases/trap-throws/keys.js > D third_party/js/proxies/TestCases/trap-throws/set.js > D third_party/js/proxies/TestCases/trap-throws/util.js > D third_party/js/proxies/consolerunner.js > D third_party/js/proxies/example.js > D third_party/js/proxies/genhtmltests > D third_party/js/proxies/gentests > D third_party/js/proxies/license.html > D third_party/js/proxies/proxytests.html > D third_party/js/proxies/proxytests.js > > > -- > > ---You received this message because you are subscribed to the Google Groups > "Google Caja Discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out.
-- Mike Stay - [email protected] http://www.cs.auckland.ac.nz/~mike http://reperiendi.wordpress.com -- --- You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
