lgtm
https://codereview.appspot.com/14347044/diff/1/build.xml
File build.xml (right):
https://codereview.appspot.com/14347044/diff/1/build.xml#newcode1087
build.xml:1087: <include name="**/caja/es53.js"/><!-- es53 legacy -->
Wondering why we still need this.
https://codereview.appspot.com/14347044/diff/1/src/com/google/caja/plugin/caja.js
File src/com/google/caja/plugin/caja.js (right):
https://codereview.appspot.com/14347044/diff/1/src/com/google/caja/plugin/caja.js#newcode340
src/com/google/caja/plugin/caja.js:340: throw new Error('es5Mode: false
is no longer supported');
Cool!
https://codereview.appspot.com/14347044/diff/1/src/com/google/caja/plugin/ses-frame-group.js
File src/com/google/caja/plugin/ses-frame-group.js (right):
https://codereview.appspot.com/14347044/diff/1/src/com/google/caja/plugin/ses-frame-group.js#newcode44
src/com/google/caja/plugin/ses-frame-group.js:44: // post-ES5/3 world.
Consider maybe annotating all TODOs about ES5/3 removal with a specific
tag so we can search/replace for them and so know when our ES5/3
transition is "done"?
https://codereview.appspot.com/14347044/diff/1/src/com/google/caja/plugin/taming-membrane.js
File src/com/google/caja/plugin/taming-membrane.js (right):
https://codereview.appspot.com/14347044/diff/1/src/com/google/caja/plugin/taming-membrane.js#newcode22
src/com/google/caja/plugin/taming-membrane.js:22: function
TamingMembrane(privilegedAccess, schema) {
Would be redundant with your TODO in ses-frame-group.js, but worth
putting in a redundant TODO that privilegedAccess.* operations are
subject to a review for whether needed in SES-only.
https://codereview.appspot.com/14347044/diff/1/tests/com/google/caja/plugin/test-mitigating-url-rewriter.js
File tests/com/google/caja/plugin/test-mitigating-url-rewriter.js
(right):
https://codereview.appspot.com/14347044/diff/1/tests/com/google/caja/plugin/test-mitigating-url-rewriter.js#newcode33
tests/com/google/caja/plugin/test-mitigating-url-rewriter.js:33: return
(uri.getPath() == before) ? after : null;
Use "===" here?
https://codereview.appspot.com/14347044/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
