Felix, do you want to weigh in on this one?
https://codereview.appspot.com/14347044/diff/1/build.xml
File build.xml (right):
https://codereview.appspot.com/14347044/diff/1/build.xml#newcode1087
build.xml:1087: <include name="**/caja/es53.js"/><!-- es53 legacy -->
On 2013/10/04 04:31:07, ihab.awad wrote:
Wondering why we still need this.
There are still headless tests for ES5/3 rewriting and execution. Those
will be killed later.
https://codereview.appspot.com/14347044/diff/1/src/com/google/caja/plugin/ses-frame-group.js
File src/com/google/caja/plugin/ses-frame-group.js (right):
https://codereview.appspot.com/14347044/diff/1/src/com/google/caja/plugin/ses-frame-group.js#newcode44
src/com/google/caja/plugin/ses-frame-group.js:44: // post-ES5/3 world.
On 2013/10/04 04:31:07, ihab.awad wrote:
Consider maybe annotating all TODOs about ES5/3 removal with a
specific tag so
we can search/replace for them and so know when our ES5/3 transition
is
"done"?
Is searching for "ES5/3" not sufficient?
https://codereview.appspot.com/14347044/diff/1/src/com/google/caja/plugin/taming-membrane.js
File src/com/google/caja/plugin/taming-membrane.js (right):
https://codereview.appspot.com/14347044/diff/1/src/com/google/caja/plugin/taming-membrane.js#newcode22
src/com/google/caja/plugin/taming-membrane.js:22: function
TamingMembrane(privilegedAccess, schema) {
On 2013/10/04 04:31:07, ihab.awad wrote:
Would be redundant with your TODO in ses-frame-group.js, but worth
putting
in a redundant TODO that privilegedAccess.* operations are subject to
a
review for whether needed in SES-only.
Done.
https://codereview.appspot.com/14347044/diff/1/tests/com/google/caja/plugin/test-mitigating-url-rewriter.js
File tests/com/google/caja/plugin/test-mitigating-url-rewriter.js
(right):
https://codereview.appspot.com/14347044/diff/1/tests/com/google/caja/plugin/test-mitigating-url-rewriter.js#newcode33
tests/com/google/caja/plugin/test-mitigating-url-rewriter.js:33: return
(uri.getPath() == before) ? after : null;
On 2013/10/04 04:31:07, ihab.awad wrote:
Use "===" here?
Done.
https://codereview.appspot.com/14347044/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
