lgtm++
The only caveats are the couple of places where it seemed we could go
further, but that's not a biggie inasmuch as this is not the only or the
last cleanup CL. :)
https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/css/CssParser.java
File src/com/google/caja/parser/css/CssParser.java (right):
https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/css/CssParser.java#newcode158
src/com/google/caja/parser/css/CssParser.java:158: public final class
CssParser {
According to my IDE (I patched in your change), nothing in this class is
used any longer.
https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/quasiliteral/QuasiBuilder.java
File src/com/google/caja/parser/quasiliteral/QuasiBuilder.java (right):
https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/quasiliteral/QuasiBuilder.java#newcode59
src/com/google/caja/parser/quasiliteral/QuasiBuilder.java:59: public
class QuasiBuilder {
This stuff seems to only be used from tests that don't look all that
useful. Are you sure we can't get rid of it entirely right now?
https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/quasiliteral/Scope.java
File src/com/google/caja/parser/quasiliteral/Scope.java (right):
https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/quasiliteral/Scope.java#newcode59
src/com/google/caja/parser/quasiliteral/Scope.java:59: public class
Scope {
This class is only used from com.google.caja.ancillary.opt. Can it be
getriddified now?
https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/quasiliteral/Scope.java#newcode295
src/com/google/caja/parser/quasiliteral/Scope.java:295:
FilePosition.UNKNOWN, "temp" + (s.tempVariableCounter++) + "_");
Y U H8 KITTEHS?
https://codereview.appspot.com/14439065/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
