https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/css/CssParser.java
File src/com/google/caja/parser/css/CssParser.java (right):
https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/css/CssParser.java#newcode158
src/com/google/caja/parser/css/CssParser.java:158: public final class
CssParser {
On 2013/10/17 03:32:30, ihab.awad wrote:
According to my IDE (I patched in your change), nothing in this class
is used
any longer.
2-arg unescape is used by CssPropertySignature. I have moved it there
and made it private.
https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/quasiliteral/QuasiBuilder.java
File src/com/google/caja/parser/quasiliteral/QuasiBuilder.java (right):
https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/quasiliteral/QuasiBuilder.java#newcode59
src/com/google/caja/parser/quasiliteral/QuasiBuilder.java:59: public
class QuasiBuilder {
On 2013/10/17 03:32:30, ihab.awad wrote:
This stuff seems to only be used from tests that don't look all that
useful.
Are you sure we can't get rid of it entirely right now?
Something's wrong with your analysis, then. It's used at least in the
cajoling service (constructing the JSON(P) response safely) and in the
CSS/HTML schema file generation.
We might be able to delete some now-unused pieces but that doesn't seem
all that useful towards our goal; better to focus on removing whole
classes for now.
https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/quasiliteral/Scope.java
File src/com/google/caja/parser/quasiliteral/Scope.java (right):
https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/quasiliteral/Scope.java#newcode59
src/com/google/caja/parser/quasiliteral/Scope.java:59: public class
Scope {
On 2013/10/17 03:32:30, ihab.awad wrote:
This class is only used from com.google.caja.ancillary.opt. Can it be
getriddified now?
.ancillary.opt is our JS minifier, which we still use. I believe we have
talked about switching to Closure Compiler for minification — should
that be put on the to-do list?
https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/quasiliteral/Scope.java#newcode295
src/com/google/caja/parser/quasiliteral/Scope.java:295:
FilePosition.UNKNOWN, "temp" + (s.tempVariableCounter++) + "_");
On 2013/10/17 03:32:30, ihab.awad wrote:
Y U H8 KITTEHS?
I misunderstood what the comment was referring to. Restored.
https://codereview.appspot.com/14439065/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
