https://codereview.appspot.com/33640043/diff/1/src/com/google/caja/lang/css/CssPropBit.java
File src/com/google/caja/lang/css/CssPropBit.java (right):
https://codereview.appspot.com/33640043/diff/1/src/com/google/caja/lang/css/CssPropBit.java#newcode33
src/com/google/caja/lang/css/CssPropBit.java:33: // 32 is an obsolete
flag HISTORY_INSENSITIVE
Please add a comment explaining what the intended disposition is: Is
this bit position
(a) never to be used again,
(b) held simply to avoid unnecessarily renumbering other flags, or
(c) to be left unused for a version-skew-avoiding time period, and then
available for use later?
As it is, the comment doesn't indicate how future developers should
treat 32 and 256.
https://codereview.appspot.com/33640043/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):
https://codereview.appspot.com/33640043/diff/1/src/com/google/caja/plugin/domado.js#newcode3572
src/com/google/caja/plugin/domado.js:3572: var safeSelectors =
sanitizeCssSelectors(
Why this renaming? The selector is virtualized, which means that e.g.
"foo" is rewritten to "caja-v-foo". This concept is independent of
history-sensitivity.
https://codereview.appspot.com/33640043/diff/1/src/com/google/caja/plugin/sanitizecss.js
File src/com/google/caja/plugin/sanitizecss.js (right):
https://codereview.appspot.com/33640043/diff/1/src/com/google/caja/plugin/sanitizecss.js#newcode415
src/com/google/caja/plugin/sanitizecss.js:415: * an empty array. (The
second used to be history-sensitive selectors.)
File an issue to later clean this up by eliminating the tuple and empty
array, marked as an API change?
https://codereview.appspot.com/33640043/diff/1/tests/com/google/caja/plugin/CssRewriterTest.java
File tests/com/google/caja/plugin/CssRewriterTest.java (right):
https://codereview.appspot.com/33640043/diff/1/tests/com/google/caja/plugin/CssRewriterTest.java#newcode171
tests/com/google/caja/plugin/CssRewriterTest.java:171: assertNoErrors();
+1
https://codereview.appspot.com/33640043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
