new snapshot
https://codereview.appspot.com/33640043/diff/1/src/com/google/caja/lang/css/CssPropBit.java
File src/com/google/caja/lang/css/CssPropBit.java (right):
https://codereview.appspot.com/33640043/diff/1/src/com/google/caja/lang/css/CssPropBit.java#newcode33
src/com/google/caja/lang/css/CssPropBit.java:33: // 32 is an obsolete
flag HISTORY_INSENSITIVE
On 2013/11/27 17:46:09, kpreid2 wrote:
Please add a comment explaining what the intended disposition is: Is
this bit
position
(a) never to be used again,
(b) held simply to avoid unnecessarily renumbering other flags, or
(c) to be left unused for a version-skew-avoiding time period, and
then
available for use later?
As it is, the comment doesn't indicate how future developers should
treat 32 and
256.
I have no idea how future developers should treat 32 and 256. All of the
options you describe sound plausible, and I think it's best to defer
judgement to whoever it is that wants to add a flag in the future. I
guess I can add a comment saying, "No idea what you should do if you
want to add a flag", but that seems pointless?
https://codereview.appspot.com/33640043/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):
https://codereview.appspot.com/33640043/diff/1/src/com/google/caja/plugin/domado.js#newcode3572
src/com/google/caja/plugin/domado.js:3572: var safeSelectors =
sanitizeCssSelectors(
On 2013/11/27 17:46:09, kpreid2 wrote:
Why this renaming? The selector is virtualized, which means that e.g.
"foo" is
rewritten to "caja-v-foo". This concept is independent of
history-sensitivity.
They're not just virtualized, they're also filtered. Neither
"safeSelectors" nor "virtualizedSelectors" is really accurate. I'll
rename to "sanitizedSelectors".
https://codereview.appspot.com/33640043/diff/1/src/com/google/caja/plugin/sanitizecss.js
File src/com/google/caja/plugin/sanitizecss.js (right):
https://codereview.appspot.com/33640043/diff/1/src/com/google/caja/plugin/sanitizecss.js#newcode415
src/com/google/caja/plugin/sanitizecss.js:415: * an empty array. (The
second used to be history-sensitive selectors.)
On 2013/11/27 17:46:09, kpreid2 wrote:
File an issue to later clean this up by eliminating the tuple and
empty array,
marked as an API change?
I can't find any external refs to sanitizeCssSelectors. I'll just change
the API and rename it, so that anyone depending on it will break
visibly.
https://codereview.appspot.com/33640043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
