lgtm
https://codereview.appspot.com/43650043/diff/1/src/com/google/caja/service/ProxyServlet.java
File src/com/google/caja/service/ProxyServlet.java (right):
https://codereview.appspot.com/43650043/diff/1/src/com/google/caja/service/ProxyServlet.java#newcode70
src/com/google/caja/service/ProxyServlet.java:70: // TODO(kpreid): This
code needs cleanup; it has many relics of its origin
most of my potential comments are basically this, so it doesn't seem
necessary to elaborate further
https://codereview.appspot.com/43650043/diff/1/src/com/google/caja/service/ProxyServlet.java#newcode96
src/com/google/caja/service/ProxyServlet.java:96: * @deprecated Do not
use this; instead pass in the correct host argument
there are three other constructors, none of them take just a host
argument.
https://codereview.appspot.com/43650043/diff/1/src/com/google/caja/service/ProxyServlet.java#newcode369
src/com/google/caja/service/ProxyServlet.java:369: // regarding what
constitutes a JS identifier.
this implementation seems pretty bizarre to me. maybe add a todo to
rethink this?
https://codereview.appspot.com/43650043/diff/1/tests/com/google/caja/service/ProxyServletTest.java
File tests/com/google/caja/service/ProxyServletTest.java (right):
https://codereview.appspot.com/43650043/diff/1/tests/com/google/caja/service/ProxyServletTest.java#newcode72
tests/com/google/caja/service/ProxyServletTest.java:72: public void
testCheckIdentifier() throws Exception {
final
https://codereview.appspot.com/43650043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
