New snapshot.
As well as changes noted below, I deleted some more dead code, namely
ModuleManager and some subclasses of BuildInfo. (BuildInfo is now only
used for the playground's version display, I think, and can go away when
we replace the playground.)
https://codereview.appspot.com/43650043/diff/1/src/com/google/caja/service/ProxyServlet.java
File src/com/google/caja/service/ProxyServlet.java (right):
https://codereview.appspot.com/43650043/diff/1/src/com/google/caja/service/ProxyServlet.java#newcode96
src/com/google/caja/service/ProxyServlet.java:96: * @deprecated Do not
use this; instead pass in the correct host argument
On 2013/12/18 19:43:24, felix8a wrote:
there are three other constructors, none of them take just a host
argument.
It seems that nothing except the UriFetcher is actually used any more,
so deleted that stuff. The zero-argument ctor is no longer marked
deprecated.
https://codereview.appspot.com/43650043/diff/1/src/com/google/caja/service/ProxyServlet.java#newcode369
src/com/google/caja/service/ProxyServlet.java:369: // regarding what
constitutes a JS identifier.
On 2013/12/18 19:43:24, felix8a wrote:
this implementation seems pretty bizarre to me. maybe add a todo to
rethink
this?
Done.
https://codereview.appspot.com/43650043/diff/1/tests/com/google/caja/service/ProxyServletTest.java
File tests/com/google/caja/service/ProxyServletTest.java (right):
https://codereview.appspot.com/43650043/diff/1/tests/com/google/caja/service/ProxyServletTest.java#newcode72
tests/com/google/caja/service/ProxyServletTest.java:72: public void
testCheckIdentifier() throws Exception {
On 2013/12/18 19:43:24, felix8a wrote:
final
Done.
https://codereview.appspot.com/43650043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
