Reviewers: felix8a,
Description:
* tabindex is allowed on any element.
* tabindex="-1" is allowed.
Please review this at https://codereview.appspot.com/85040043/
Affected files (+4, -20 lines):
M src/com/google/caja/lang/html/html4-attributes-defs.json
M src/com/google/caja/lang/html/html4-attributes-whitelist.json
Index: src/com/google/caja/lang/html/html4-attributes-defs.json
===================================================================
--- src/com/google/caja/lang/html/html4-attributes-defs.json (revision 5676)
+++ src/com/google/caja/lang/html/html4-attributes-defs.json (working copy)
@@ -558,20 +558,9 @@
{ "key": "TABLE::SUMMARY",
"description": "purpose/structure for speech output",
"optional": true },
- { "key": "A::TABINDEX", "description": "position in tabbing order",
- "pattern": "[0-9]+", "optional": true },
- { "key": "AREA::TABINDEX", "description": "position in tabbing
order",
- "pattern": "[0-9]+", "optional": true },
- { "key": "BUTTON::TABINDEX", "description": "position in tabbing
order",
- "pattern": "[0-9]+", "optional": true },
- { "key": "INPUT::TABINDEX", "description": "position in tabbing
order",
- "pattern": "[0-9]+", "optional": true },
- { "key": "OBJECT::TABINDEX", "description": "position in tabbing
order",
- "pattern": "[0-9]+", "optional": true },
- { "key": "SELECT::TABINDEX", "description": "position in tabbing
order",
- "pattern": "[0-9]+", "optional": true },
- { "key": "TEXTAREA::TABINDEX", "description": "position in tabbing
order",
- "pattern": "[0-9]+", "optional": true },
+ { "key": "*::TABINDEX", "description": "position in tabbing order",
+ "pattern": "-1|[0-9]+", "optional": true,
+ "comment": "-1 and on-any-element are extensions/HTML5" },
{ "key": "A::TARGET", "description": "render in this frame",
"type": "FRAME_TARGET", "default": "_self", "optional": true },
{ "key": "AREA::TARGET", "description": "render in this frame",
Index: src/com/google/caja/lang/html/html4-attributes-whitelist.json
===================================================================
--- src/com/google/caja/lang/html/html4-attributes-whitelist.json (revision
5676)
+++ src/com/google/caja/lang/html/html4-attributes-whitelist.json (working
copy)
@@ -193,12 +193,7 @@
"OL::START",
"*::STYLE",
"TABLE::SUMMARY",
- "A::TABINDEX",
- "AREA::TABINDEX",
- "BUTTON::TABINDEX",
- "INPUT::TABINDEX",
- "SELECT::TABINDEX",
- "TEXTAREA::TABINDEX",
+ "*::TABINDEX",
"A::TARGET",
"AREA::TARGET",
"FORM::TARGET",
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
