On 2014/04/07 19:20:40, kpreid_google wrote:
On 2014/04/07 18:31:06, felix8a wrote:
> lgtm.
>
> you might want to add a testcase in
tests/.../plugin/css-stylesheet-tests.js
I don't think we need tests for things that are purely set by the
schema files
and don't interact with any other features.
I've done it before for a few css/html whitelist items because
- the processing of the schema is nontrivial, so I don't have high
confidence that I understand how my source text will become behavior
- it's pattern matching, not just a list of strings, and I don't have
high confidence I can write typo-free patterns
Code review is a reasonable antidote to those problems, but there's only
a handful of people who understand this code, so tests might be a
helpful redundancy.
https://codereview.appspot.com/85040043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
