LGTM
https://codereview.appspot.com/121970043/diff/80001/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/121970043/diff/80001/src/com/google/caja/ses/repairES5.js#newcode704
src/com/google/caja/ses/repairES5.js:704: cacheLine =
standinMakerCache.get((standinName = 'standin'));
Please put the assignment on the previous line; this is obscurity to
little benefit.
https://codereview.appspot.com/121970043/diff/80001/src/com/google/caja/ses/repairES5.js#newcode707
src/com/google/caja/ses/repairES5.js:707:
standinMakerCache.set(standinName, ((cacheLine = [])));
Same: please separate the assignment.
I would have instead made up a key by concatenating the function name
and arity, so the cache is a single-level data structure, but this seems
OK too.
https://codereview.appspot.com/121970043/diff/80001/src/com/google/caja/ses/repairES5.js#newcode721
src/com/google/caja/ses/repairES5.js:721: cacheLine[arity] = ((result =
unsafeEval(makeStandinSrc)));
separate assignment
https://codereview.appspot.com/121970043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
