https://codereview.appspot.com/121970043/diff/80001/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/121970043/diff/80001/src/com/google/caja/ses/repairES5.js#newcode704
src/com/google/caja/ses/repairES5.js:704: cacheLine =
standinMakerCache.get((standinName = 'standin'));
On 2014/08/04 16:54:26, kpreid2 wrote:
Please put the assignment on the previous line; this is obscurity to
little
benefit.
Done.
https://codereview.appspot.com/121970043/diff/80001/src/com/google/caja/ses/repairES5.js#newcode707
src/com/google/caja/ses/repairES5.js:707:
standinMakerCache.set(standinName, ((cacheLine = [])));
On 2014/08/04 16:54:26, kpreid2 wrote:
Same: please separate the assignment.
Done
I would have instead made up a key by concatenating the function name
and arity,
so the cache is a single-level data structure, but this seems OK too.
This way, I get to reuse the first level for the blacklist check.
https://codereview.appspot.com/121970043/diff/80001/src/com/google/caja/ses/repairES5.js#newcode721
src/com/google/caja/ses/repairES5.js:721: cacheLine[arity] = ((result =
unsafeEval(makeStandinSrc)));
On 2014/08/04 16:54:26, kpreid2 wrote:
separate assignment
Done.
https://codereview.appspot.com/121970043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
