https://codereview.appspot.com/124480043/diff/1/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/124480043/diff/1/src/com/google/caja/ses/repairES5.js#newcode2176
src/com/google/caja/ses/repairES5.js:2176: function
test_SPLICE_IGNORES_READONLY() {
Because these have such uniform structure, please shorten them and
remove possibilities of cut-and-paste/partial-update errors by
abstracting the common parts.
See arrayMutatorProblem() for a closely related example. (I don't think
arrayMutatorProblem itself can be adapted for this problem cleanly, but
if you see a good readable way to do so, please do.)
https://codereview.appspot.com/124480043/diff/1/src/com/google/caja/ses/repairES5.js#newcode4573
src/com/google/caja/ses/repairES5.js:4573: preSeverity:
severities.UNSAFE_SPEC_VIOLATION,
If these are UNSAFE_SPEC_VIOLATIONs, then we need to do something about
them for Caja. In line with our previous decisions, I think they should
be added to the acceptableProblems (if I have the name right) list since
Caja does not rely on less-than-completely-frozen objects.
Verify the settings using, say, the generic-host-page: it should succeed
in running guest content when the allowable severity is set to
NO_KNOWN_EXPLOIT_SPEC_VIOLATION.
https://codereview.appspot.com/124480043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
