https://codereview.appspot.com/124480043/diff/1/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/124480043/diff/1/src/com/google/caja/ses/repairES5.js#newcode4573
src/com/google/caja/ses/repairES5.js:4573: preSeverity:
severities.UNSAFE_SPEC_VIOLATION,
On 2014/08/18 19:14:03, kpreid_google wrote:
On 2014/08/18 14:00:00, MarkM wrote:
> On all browsers, all tests that they initially fail are repaired
successfully.
OK, that's fine then. I didn't realize you were adding tests for
problems beyond
the ones we're actually seeing.
Acknowledged.
https://codereview.appspot.com/124480043/diff/20001/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/124480043/diff/20001/src/com/google/caja/ses/repairES5.js#newcode3283
src/com/google/caja/ses/repairES5.js:3283: splice.apply(this,
concat.call([0, 0], items));
On 2014/08/18 19:14:03, kpreid_google wrote:
In general, I think we shouldn't use a top-level captured function,
but use one
you capture when the repair function executes. This ensures that in
the future
if we have a repair affecting splice, they "layer" rather than
bypassing each
other.
(This still might be a bad result depending on which order the repairs
execute
in, but I claim that this pattern is more robust in general.)
Done.
https://codereview.appspot.com/124480043/diff/20001/src/com/google/caja/ses/repairES5.js#newcode3295
src/com/google/caja/ses/repairES5.js:3295: if (len <= 0) { return void
0; }
On 2014/08/18 19:14:03, kpreid_google wrote:
Does this do the right thing if len is NaN?
No. Good catch.
Done.
https://codereview.appspot.com/124480043/diff/20001/src/com/google/caja/ses/repairES5.js#newcode3297
src/com/google/caja/ses/repairES5.js:3297: splice.apply(this,
concat.call([0, 1], []));
On 2014/08/18 19:14:03, kpreid_google wrote:
capturing again
Done.
https://codereview.appspot.com/124480043/diff/20001/src/com/google/caja/ses/repairES5.js#newcode3726
src/com/google/caja/ses/repairES5.js:3726: function
arrayMutatorProblem(destination, prop, testArgs) {
On 2014/08/18 19:14:03, kpreid_google wrote:
The name arrayMutatorProblem is now too generic and ought to be
changed; please
add a TODO to note the need for a better one (I don't have any good
ideas).
Done. Rather than TODO, I changed it arraySealProblem.
https://codereview.appspot.com/124480043/diff/20001/src/com/google/caja/ses/repairES5.js#newcode4747
src/com/google/caja/ses/repairES5.js:4747:
arrayPutProblem(supportedProblems,
On 2014/08/18 19:14:03, kpreid_google wrote:
Please add comments giving the computed names of these problems, as
done for
arrayMutatorProblem below. This allows searching the source file for a
problem's
definition.
Done.
https://codereview.appspot.com/124480043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
