[google-guice] limpbizkit commented on revision r720. Details are at http://code.google.com/p/google-guice/source/detail?r=720
Score: Neutral General Comment: Chris - questions for you below... Line-by-line comments: File: /trunk/src/com/google/inject/ProxyFactory.java (r720) =============================================================================== Line 117: Callback[] callbacks = new Callback[methods.size()]; ------------------------------------------------------------------------------- Fixed. I've clearly gotten too reliant on IntelliJ to point out mistakes like this one. (Arrays.fill() throws off the unused variable detection) Line 118: Arrays.fill(callbackTypes, net.sf.cglib.proxy.MethodInterceptor.class); ------------------------------------------------------------------------------- Comment by chris.nokleberg, Today (2 hours ago): > FYI this will possibly have a negative performance impact--a no-op method interceptor is more expensive than NoOp.class (mostly due to creating the arguments array + auto-boxing) I'd like to reuse the same enhanced class across different configurations of callbacks. Will NoOp.class work if I only set the callback types one time? Line 213: private final Class<?> declaringClass; ------------------------------------------------------------------------------- Fixed. Respond to these comments at http://code.google.com/p/google-guice/source/detail?r=720 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/google-guice-dev?hl=en -~----------~----~----~----~------~----~------~--~---
