Author: limpbizkit
Date: Sun Dec  7 17:30:42 2008
New Revision: 722

Modified:
    trunk/src/com/google/inject/ProxyFactory.java

Log:
Applying 2 of 3 fixes from chris.nokleberg's code review...

Modified: trunk/src/com/google/inject/ProxyFactory.java
==============================================================================
--- trunk/src/com/google/inject/ProxyFactory.java       (original)
+++ trunk/src/com/google/inject/ProxyFactory.java       Sun Dec  7 17:30:42 2008
@@ -114,9 +114,7 @@

      @SuppressWarnings("unchecked")
      Class<? extends Callback>[] callbackTypes = new Class[methods.size()];
-    Callback[] callbacks = new Callback[methods.size()];
      Arrays.fill(callbackTypes, net.sf.cglib.proxy.MethodInterceptor.class);
-    Arrays.fill(callbacks, NO_OP_METHOD_INTERCEPTOR);

      // Create the proxied class. We're careful to ensure that all enhancer  
state is not-specific to
      // this injector. Otherwise, the proxies for each injector will waste  
Permgen memory
@@ -210,8 +208,8 @@
     * declaring class so that enhanced classes can be shared between  
injectors.
     */
    private static class IndicesCallbackFilter implements CallbackFilter {
-    private final Class<?> declaringClass;
-    private final Map<Method, Integer> indices;
+    final Class<?> declaringClass;
+    final Map<Method, Integer> indices;

      public IndicesCallbackFilter(Class<?> declaringClass, List<Method>  
methods) {
        this.declaringClass = declaringClass;

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"google-guice-dev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/google-guice-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to