rwallace1979 commented on branch /branches/2.0-maven in project google-guice. Details are at http://code.google.com/p/google-guice/source/branch?spec=issue393&branch=%2Fbranches%2F2.0-maven
Score: Neutral General Comment: Should the extension artifactIds be prefixed with "guice-"? I don't have a problem with them being in the com.google.inject.extension groupId, but am wondering if the artifactIds should be more descriptive, otherwise people will wind up with the files named "assisted-inject-2.0.jar", "throwingproviders-2.0.jar", and probably the example that best shows why I think they should be prefixed with "guice-" is "jmx-2.0.jar". If that gets fixed up I think everything else looks good. Respond to these comments at http://code.google.com/p/google-guice/source/branch?spec=issue393&branch=%2Fbranches%2F2.0-maven -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/google-guice-dev?hl=en -~----------~----~----~----~------~----~------~--~---
