limpbizkit commented on branch /branches/2.0-maven in project google-guice. Details are at http://code.google.com/p/google-guice/source/branch?spec=issue393&branch=%2Fbranches%2F2.0-maven
Score: Neutral General Comment: Thanks Greg! Line-by-line comments: File: /branches/2.0-maven/extensions/assistedinject/pom.xml (r1016) =============================================================================== Line 6: <groupId>com.google.inject.extension</groupId> ------------------------------------------------------------------------------- do we need a group for extensions? File: /branches/2.0-maven/guice-parent/pom.xml (r1016) =============================================================================== Line 11: <artifactId>guice-parent</artifactId> ------------------------------------------------------------------------------- I guess I don't get Maven - what's the point of this file? Can't the core Guice POM be the parent? File: /branches/2.0-maven/integration-parent/pom.xml (r1016) =============================================================================== Line 13: <name>Google Guice - Integration</name> ------------------------------------------------------------------------------- Please smash together extensions and integrations. There isn't much of a functional difference, and so in the next version I intend to move spring, servlet etc. into the extensions/ subfolder. Respond to these comments at http://code.google.com/p/google-guice/source/branch?spec=issue393&branch=%2Fbranches%2F2.0-maven -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/google-guice-dev?hl=en -~----------~----~----~----~------~----~------~--~---
