dhanji commented on revision r1022 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=1022
Score: Positive
General Comment:
LGTM
This is great!
Line-by-line comments:
File: /trunk/src/com/google/inject/internal/BindingProcessor.java (r1022)
===============================================================================
Line 164: BindingImpl<T> binding =
injector.createUnitializedBinding(key, scoping, source, errors);
-------------------------------------------------------------------------------
typo: Uninitialized
Line 275: // all our unit tests.
-------------------------------------------------------------------------------
It's very unfortunate, given that this means there is no way we can forbid
ServletModule from being bound...
What might be better is to use an annotation:
@ForbiddenType
File: /trunk/src/com/google/inject/internal/ConstructorBindingImpl.java
(r1022)
===============================================================================
Line 70: if (Modifier.isAbstract(rawType.getModifiers())) {
-------------------------------------------------------------------------------
I assume this also checks for interfaces?
File: /trunk/src/com/google/inject/spi/InjectionPoint.java (r1022)
===============================================================================
Line 181: * type literal.
-------------------------------------------------------------------------------
lol, not {...@linkplain forConstructor(...)}?
File: /trunk/test/com/google/inject/BindingTest.java (r1022)
===============================================================================
Line 211: public void testToConstructorBindings() throws
NoSuchMethodException {
-------------------------------------------------------------------------------
Hooray!
Respond to these comments at
http://code.google.com/p/google-guice/source/detail?r=1022
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
