limpbizkit commented on revision r1022 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=1022
Score: Neutral
General Comment:
Thanks for the review Dhanji. I've addressed the typos in r1026.
Line-by-line comments:
File: /trunk/src/com/google/inject/internal/ConstructorBindingImpl.java
(r1022)
===============================================================================
Line 70: if (Modifier.isAbstract(rawType.getModifiers())) {
-------------------------------------------------------------------------------
> I assume this also checks for interfaces?
I'm unsure. In any case, that'll still fail since interfaces don't have
constructors. I think the motivation behind this check is for interceptors,
so we don't accidentally subclass an abstract class and make it instantiable
File: /trunk/src/com/google/inject/spi/InjectionPoint.java (r1022)
===============================================================================
Line 181: * type literal.
-------------------------------------------------------------------------------
> lol, not {...@linkplain forConstructor(...)}?
I don't get your comment. I'm trying to refer to the parameter
named "constructor", not the type "Constructor" (although I admit that in
this instance they're easily confused)
Respond to these comments at
http://code.google.com/p/google-guice/source/detail?r=1022
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
