On 03/06/10 15:31, [email protected] wrote: > On Apr 22, 3:11 am, Max Bowsher <[email protected]> wrote: >> On further inspection, it turns out that about a third are general >> utility common code. I would like to propose that such classes move to >> com.google.inject.internal.util (or similar) to render the package >> containing the core internal logic of Guice less crowded. > > Moving these classes is a fine idea, but it will cause pain for any > developer who has mistakenly imported Guice's ImmutableSet (etc.) > rather than that from Guava. > > Unfortunately IDEs have a habit of importing the wrong package on a > user's behalf, which makes this mistake somewhat common. > > This doesn't rule out the change completely, but it does make it > significantly less compelling.
I think that the fact that all of these classes are in a package with .internal. in its name ought to be a strong warning to any developer that they have no right to expect it to maintain API compatibility over releases. Were it not for the existing .internal. designation, I'd not even suggest doing this before Guice 3.0, but as they were in such a package, I'd suggest that doing it in 2.1 could be permissible. Thanks, Max.
signature.asc
Description: OpenPGP digital signature
