-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/10/2010 08:20 PM, Eric Burke wrote: > -1 to new external dependencies. I'd rather Guice be free to innovate > rather than tie itself to a particular version of an external library. > Not to mention the added headaches when my app already uses one version > of an external library but now Guice thinks I should have a different > version of the library, and they have conflicts.
Yeah, I see that point. But if everybody uses the solution you propose, we will end up with several **.internal.ImmutableList classes for larger projects. This doesn't scale either... So adding every lib as internal will lead into the wrong direction. And that just because it *might* be possible for some projects that there is an incompatible version clash. So what can we do to about that? Maybe two different versions? Adds a lot of complexity to the build process... In Maven land that could be useful: http://mojo.codehaus.org/minijar-maven-plugin Never tried it myself... - --> Default case for "normal" projects: External dependency to Guava - --> Special case for Android/avoiding-dep-problems users Regards, Johannes > Furthermore, Guice works well on Android now. Adding external library > dependencies may make this more complicated. > > > On Thu, Jun 10, 2010 at 11:11 AM, Christian Edward Gruber > <[email protected] <mailto:[email protected]>> wrote: > > +1. > > On Jun 10, 2010, at 7:04 AM, Johannes Schneider wrote: > >> On 06/03/2010 04:31 PM, [email protected] <mailto:[email protected]> wrote: >>> Moving these classes is a fine idea, but it will cause pain for any >>> developer who has mistakenly imported Guice's ImmutableSet (etc.) >>> rather than that from Guava. >> >> Maybe it is a good idea to remove that "interal" classes completly and >> instead create a dependency to Guava? >> >> In nearly every project, I have many duplicates... > > -- > You received this message because you are subscribed to the Google > Groups "google-guice-dev" group. > To post to this group, send email to > [email protected] > <mailto:[email protected]>. > To unsubscribe from this group, send email to > [email protected] > <mailto:google-guice-dev%[email protected]>. > For more options, visit this group at > http://groups.google.com/group/google-guice-dev?hl=en. > > > > > -- > Eric M. Burke > http://www.linkedin.com/in/ericburke > 314-494-3185 (mobile) > 636-294-0191 (home) > > -- > You received this message because you are subscribed to the Google > Groups "google-guice-dev" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/google-guice-dev?hl=en. - -- Johannes Schneider - blog.cedarsoft.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQEcBAEBAgAGBQJMETDsAAoJEAytD9R7Qv6dNrgH/3N4GRG2x/KQIv37RLmvJx1V ZqJwZEenpp/Q8k/dzDmIqcJbve/OaBatjrkmUaD+Az+0Uer3Hjd2gDay1SX6bAcR 65mx6n19axrkVoETIdXg1keRCViXtKb/ilpWG4UiAqi2Jda+bOHmfNlqPUKZjEOs rjGHLVf0iWQ6E/f3aG/ySUi/zfMDnYAn/fuhz0Hq5Ld8HX3a8dBpFPU7arp/2rx7 YK6k5qcNv2v+HRjZTJVmuGpaF5jMjgaiuR/QaHXg2jHX7Ykm0hU9Pawt+uR+h30b KfC60J1AERClUDlvAw51cSZZ+Wj6fPhUZ7WI/dEnfBx+Q9a/zFvC1YhsshHS3cA= =x7AQ -----END PGP SIGNATURE----- -- You received this message because you are subscribed to the Google Groups "google-guice-dev" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-guice-dev?hl=en.
