On 07/07/10 01:29, Dhanji R. Prasanna wrote:
> Does it? It only installs PersistenceFilter if you specify unit of work
> as request. So in a non-servlet app it will never load that class.
> 
> We might do as you suggest anyway though--haven't quite finalized the
> design of how PersistFilter should work..

I'm not thinking of a non-servlet app - rather I'm thinking of a servlet
application that wants to use guice-persist in UnitOfWork.REQUEST mode,
but doesn't want to involve guice-servlet.

Max.


> On Wed, Jul 7, 2010 at 9:37 AM, Max Bowsher <[email protected]
> <mailto:[email protected]>> wrote:
> 
>     Currently guice-persist *requires* the use of guice-servlet.
> 
>     I can easily envisage an application where someone wanted to use
>     guice-persist, but was happy with pure web.xml-based servlet
>     configuration.
> 
>     To not needlessly inhibit, this, I think the PersistenceFilter class
>     should be changed from package-private to public, such that it can be
>     installed directly in web.xml, not only via PersistModule.
> 
>     Max.

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to