Won't you need to wrap the PersistenceFilter anyway if you're going to have your container instantiate it, in order to get it injected into?
-Josh On 7 July 2010 18:11, Max Bowsher <[email protected]> wrote: > On 07/07/10 08:03, Dhanji R. Prasanna wrote: > > How strange! =) > > Not really. > > Guice-Servlet is a nifty idea, but fundamentally it does bypass standard > bits of the servlet spec so that it can reimplement them itself in > (hopefully) similar ways. People may feel that this non-standardness > makes them uneasy and is not sufficiently worthwhile, especially if they > are already comfortable with an existing web.xml configuration. > > But, they could still want to use guice-persist. > > > Max. > > > > > > On Wed, Jul 7, 2010 at 11:31 AM, Max Bowsher <[email protected] > > <mailto:[email protected]>> wrote: > > > > On 07/07/10 01:29, Dhanji R. Prasanna wrote: > > > Does it? It only installs PersistenceFilter if you specify unit of > > work > > > as request. So in a non-servlet app it will never load that class. > > > > > > We might do as you suggest anyway though--haven't quite finalized > the > > > design of how PersistFilter should work.. > > > > I'm not thinking of a non-servlet app - rather I'm thinking of a > servlet > > application that wants to use guice-persist in UnitOfWork.REQUEST > mode, > > but doesn't want to involve guice-servlet. > > > > Max. > > > > > > > On Wed, Jul 7, 2010 at 9:37 AM, Max Bowsher <[email protected] > > <mailto:[email protected]> > > > <mailto:[email protected] <mailto:[email protected]>>> wrote: > > > > > > Currently guice-persist *requires* the use of guice-servlet. > > > > > > I can easily envisage an application where someone wanted to > use > > > guice-persist, but was happy with pure web.xml-based servlet > > > configuration. > > > > > > To not needlessly inhibit, this, I think the PersistenceFilter > > class > > > should be changed from package-private to public, such that it > > can be > > > installed directly in web.xml, not only via PersistModule. > > > > > > Max. > > > > > > -- > > You received this message because you are subscribed to the Google > > Groups "google-guice-dev" group. > > To post to this group, send email to [email protected]. > > To unsubscribe from this group, send email to > > [email protected]<google-guice-dev%[email protected]> > . > > For more options, visit this group at > > http://groups.google.com/group/google-guice-dev?hl=en. > > > -- "Therefore, send not to know For whom the bell tolls. It tolls for thee." Josh 'G-Funk' McDonald - [email protected] - http://twitter.com/sophistifunk - http://flex.joshmcdonald.info/ -- You received this message because you are subscribed to the Google Groups "google-guice-dev" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-guice-dev?hl=en.
