[email protected] commented on revision r1190 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=1190
Score: Positive
General Comment:
Awesome! Thanks so much for doing this cleanup. These tests were originally
TestNG tests and I converted them (rather poorly it seems) to JUnit. My IDE
(and ant test) has asserts on by default that's probably why I thought all
was right with the world =)
Line-by-line comments:
File:
/trunk/servlet/test/com/google/inject/servlet/VarargsFilterDispatchIntegrationTest.java
(r1190)
===============================================================================
Line 152: inits == 1 && doFilters == 2 && destroys == 1);
-------------------------------------------------------------------------------
Is this right? you changed the asserts from 5 inits to 1...
Respond to these comments at
http://code.google.com/p/google-guice/source/detail?r=1190
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en.
