sberlin commented on revision r1190 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=1190
Line-by-line comments:
File:
/trunk/servlet/test/com/google/inject/servlet/VarargsFilterDispatchIntegrationTest.java
(r1190)
===============================================================================
Line 152: inits == 1 && doFilters == 2 && destroys == 1);
-------------------------------------------------------------------------------
AFAICT, it's right. I think it's related to r846, which cleaned up init &
destroy so they weren't called multiple times for the same filter. In that
revision all the tests using assertTrue were cleaned up to reference the
new count of inits/destroys, but ones behind an 'assert' weren't. So after
changing these to assertTrue (or enabling assertions) they were failing. I
spot-checked against the number of times it looked like they should be
called, and it looks like all is well with the world... the numbers were
just out-dated.
Respond to these comments at
http://code.google.com/p/google-guice/source/detail?r=1190
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en.
