[email protected] commented on revision r1167 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=1167
Score: Positive
General Comment:
I'm somewhat anxious that we can't tell the residue from the proper
bindings.
Line-by-line comments:
File: /trunk/src/com/google/inject/internal/InjectorImpl.java (r1167)
===============================================================================
Line 464: private boolean cleanup(BindingImpl<?> binding, Set<Key>
encountered) {
-------------------------------------------------------------------------------
Does this risk removing too many bindings?
File: /trunk/test/com/google/inject/ImplicitBindingTest.java (r1167)
===============================================================================
Line 134: assertFailure(injector, Invalid.class);
-------------------------------------------------------------------------------
nice test
Respond to these comments at
http://code.google.com/p/google-guice/source/detail?r=1167
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en.
