sberlin commented on revision r1167 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=1167
General Comment:
Re: cleanup -- I don't think it can remove too many. The logic behind it
is:
for each dependency of the binding
if it's a newly-discovered dependency (prevent infinite circularity)
if it's a JIT binding and a BAD* binding: remove it
where BAD is defined as: any binding that is
a) a constructor binding that isn't fully initialized
or b) or had any dependencies that were BAD.
I'm pretty certain that limits it to just invalid bindings, and there's a
pretty thorough test to make sure it works like we expect it. Please speak
up if I'm missing something though!
Respond to these comments at
http://code.google.com/p/google-guice/source/detail?r=1167
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en.
