> Hmmm... > > Would you be interested in seeing what happens if you pool the Errors > objects? You'd need to go through the code and find hot calls to "new > Errors()" with something to pull them from a cache, plus something > else to return unused ones to the cache. If you try this and get > sizable performance improvements, I'll accept a patch! >
I'll take a look. It'll likely require some sort of ThreadLocal & Stack, something similar to other performance optimizations you've already done. Yeah, AssistedInject is currently a bit of a mess internally. Sooner > or later I'd like to change it from using child injectors to use the > new 'toConstructor()' API introduced after Guice 2.0. Since nobody > else is actively working on this at the moment, patches are welcome > here. > Hmmm... I'm not certain I fully understand. I see how toConstructor can match up to an arbitrary constructor (ie, that'd let you use @AssistedInject again instead of @Inject), but I don't quite see how it could remove the need for a child injector. All the examples from the tests seem to require the other parameters to the constructor as bindings in the Module. I'd love to be able to clean this up, so any pointers are welcome. > > By the way, I'm sorry that I still haven't done anything about the old > patches you've posted to our bugtracker. It's tricky business trying > to balance the API between exposing enough power, and exposing too > much! I'm still thinking things over, and in general I'd like to be a > Good Open Source Project and accept good patches. > No worries -- I know exactly how it is with patches piling up... there's a lot around here that I just haven't had a chance to look at. We patch when necessary, but for the most part the important things (most recently getAllBindings) make it in. Sam --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/google-guice?hl=en -~----------~----~----~----~------~----~------~--~---
