I committed a potential fix for this last night. It should solve the issue in nearly all use cases (it does not solve it if your assisted object injects Injector or a Provider of the assisted dependencies, but those situations should be very rare). If you're able to give the latest trunk a shot and report how it goes, that would be extremely helpful! (It requires the trunk build of Guice from atleast r1145, and AssistedInject from atleast r1147.)
Sam On Thu, Mar 25, 2010 at 2:30 AM, Kartik Kumar <[email protected]>wrote: > Hopefully the AssistedInject lock contention issue will be resolved in any > Guice release. > > > On Wed, Mar 24, 2010 at 1:05 PM, Max Bowsher <[email protected]> wrote: > >> On 24/03/10 19:28, Sam Berlin wrote: >> >>> Thinking a bit more, there's Injector.getAllBindings (get all explicit + >>> JIT bindings), I think Scopes.isSingleton, and likely a lot more. 2.0 >>> was released a long time ago! >>> >> >> Indeed! >> >> Individually, these things may be minor - but taken together, IMO, there's >> already more than enough in trunk to justify a Guice 2.1 release. >> >> Max. >> >> >> On Wed, Mar 24, 2010 at 2:24 PM, Sam Berlin <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> There's a few minor other changes, such as >>> Injector.getExistingBinding (try to get a binding w/o creating a >>> just-in-time binding if it didn't exist), and using 'new >>> InjectorBuilder()' for a better scaling pipeline of creating an >>> Injector with different options. The only currently new option is >>> 'requireExplicitBindings', which tells Guice to fail creating your >>> Injector if any dependencies aren't listed in a module (this >>> prevents against accidentally creating a just-in-time binding when >>> you didn't mean to). There's also a pending patch for issue 435 >>> (performance problems due to AssistedInject using child injectors) >>> which needs some review, but could potentially solve the problem. >>> >>> If folks are able to use the trunk and give feedback on any of the >>> changes, it would help a lot. >>> >>> Sam >>> >>> >>> On Wed, Mar 24, 2010 at 1:33 PM, Bob Lee <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> The only change I can think of is JSR-330 support. We'll >>> probably have a release in a couple months, but we don't have >>> concrete plans at the moment. >>> >>> I'd like to see circular dep detection make it into this release. >>> >>> Bob >>> >>> On Wed, Mar 17, 2010 at 1:58 PM, Max Bowsher <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> The trunk of Guice has changed quite a bit since 2.0. >>> >>> I'd like to start understanding the internals of Guice, but >>> I'm hesitant to look at 2.0, when everything has moved >>> around on trunk, but equally concerned that looking at trunk >>> whilst using 2.0 in my projects may prove frustrating. >>> >>> Plus, I'm eager to get access to bugfixes and features from >>> the current trunk, but can't really justify using a snapshot >>> in production code. >>> >>> So... what are the release plans for the next version of >>> Guice? >>> >>> Max. >>> >>> -- >>> You received this message because you are subscribed to the >>> Google Groups "google-guice" group. >>> To post to this group, send email to >>> [email protected] >>> <mailto:[email protected]>. >>> >>> To unsubscribe from this group, send email to >>> >>> [email protected]<google-guice%[email protected]> >>> >>> <mailto:google-guice%[email protected]<google-guice%[email protected]> >>> >. >>> >>> For more options, visit this group at >>> http://groups.google.com/group/google-guice?hl=en. >>> >>> >>> -- >>> You received this message because you are subscribed to the >>> Google Groups "google-guice" group. >>> To post to this group, send email to >>> [email protected] >>> <mailto:[email protected]>. >>> >>> To unsubscribe from this group, send email to >>> >>> [email protected]<google-guice%[email protected]> >>> >>> <mailto:google-guice%[email protected]<google-guice%[email protected]> >>> >. >>> >>> For more options, visit this group at >>> http://groups.google.com/group/google-guice?hl=en. >>> >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "google-guice" group. >>> To post to this group, send email to [email protected]. >>> To unsubscribe from this group, send email to >>> [email protected]<google-guice%[email protected]> >>> . >>> For more options, visit this group at >>> http://groups.google.com/group/google-guice?hl=en. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "google-guice" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]<google-guice%[email protected]> >> . >> For more options, visit this group at >> http://groups.google.com/group/google-guice?hl=en. >> >> > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<google-guice%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/google-guice?hl=en. > -- You received this message because you are subscribed to the Google Groups "google-guice" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-guice?hl=en.
