If all the dependencies we use in our apps were to embed their own private dependencies there would be a lot of code duplication. True, that would not be a show stopper nor a problem in some cases, but I guess I don't necessarily see a lot of benefit in even worrying about that. If the size becomes a problem for my app in my context, I am still able to perform my own jarjar/proguard on the integrated dependency tree to squeeze the size of the final app. -- yuri
On Tue, Jul 5, 2011 at 6:03 PM, Sam Berlin <[email protected]> wrote: > I don't understand this need for large projects to know which version gets > used. It's an implementation detail within Guice. There won't be any > version conflicts. Why does a "large project" have to be able to change the > version? > > sam > > On Tue, Jul 5, 2011 at 5:59 PM, cowwoc <[email protected]> wrote: >> >> I vote for making the common case easy and advanced case possible. >> Large projects absolutely need the flexibility to choose which dependency >> versions gets used. Simple projects prefer an all-in-use JAR file. I believe >> #4 will make everyone happy. >> >> When Maven is thrown into the picture it's even more difficult for >> users to screw things up. You get the correct versions of dependencies by >> default but you can override them if you need to. Guice should provide the >> same model... >> >> Gili >> >> On 05/07/2011 5:42 PM, Yuri de Wit wrote: >>> >>> +1 for #5. There are legit cases for needing different dependency >>> versions in larger projects and having that flexibility is a big plus. >>> Besides, for the default case, a maven or regular zip distributions >>> could automatically point or include the official, tested Guava >>> version for a given Guice version. >>> >>> -- yuri >>> >>> On Tue, Jul 5, 2011 at 4:15 PM, James Moore<[email protected]> >>> wrote: >>>> >>>> Speaking as a Guice + Guava (on Android) user, I'd vote for #5, make >>>> Guava an external dependency. >>>> >>>> 1) Do nothing (and live with the larger jar size where we basically >>>> embed all of Guava) >>>> >>>> I think this is a problem from the Android point of view. What >>>> happens when you're still on Guava r09, and I want r10? (That's the >>>> situation right now, I think, since I'm switching to trunk Guava/r10 + >>>> Guice). That's a lot of extra duplicated code to have installed. >>>> >>>> -- >>>> James Moore >>>> [email protected] >>>> http://jamesmoorecode.blogspot.com/ >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "google-guice" group. >>>> To post to this group, send email to [email protected]. >>>> To unsubscribe from this group, send email to >>>> [email protected]. >>>> For more options, visit this group at >>>> http://groups.google.com/group/google-guice?hl=en. >>>> >>>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "google-guice" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/google-guice?hl=en. >> > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/google-guice?hl=en. > -- You received this message because you are subscribed to the Google Groups "google-guice" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-guice?hl=en.
