Yeah, I see now. I have nothing against using gerrit for code reviews if folks want to do that... but overall, I think hosting the project itself on GitHub is the best option. GitHub just seems to have better community engagement tools. We generally do most development of Guice internally (with internal code reviews) anyway, since changes have to be tested over the whole corpus. For accepting occasional patches, GitHub just seems much easier... folks can easily fork, send a pull request, etc..
sam On Wed, May 28, 2014 at 10:08 AM, <[email protected]> wrote: > OK, i thought it was clear. > > I mean to host Guice development on Gerrit Code Review, > like Gerrit [1] itself and GWT library [2]. > > The code review process is much easier on Gerrit as on GH. > And of course you could still replicate to GH from Gerrit. That's what > Openstack [3], Wikimedia [4] and LibreOffice [5] projects are doing (read > only). > > I have added Shawn to this thread, as he is your man, should you decide > to go with Gerrit and create new site: > > https://guice-review.googlesource.com > > [1] https://gerrit-review.googlesource.com > [2] https://gwt-review.googlesource.com > [3] https://review.openstack.org > [4] https://gerrit.wikimedia.org > [5] https://gerrit.libreoffice.org > > > Am Mittwoch, 28. Mai 2014 15:58:13 UTC+2 schrieb Sam Berlin: >> >> That link 404s, so I'm not totally sure what you're referring to. >> googlesource.com seems to be the cover page for "open source stuff at >> google", which just links back to codesite. Google already has an >> organization at GitHub (https://github.com/google), so this would just >> fit as another project in there. >> >> sam >> >> >> On Wed, May 28, 2014 at 9:19 AM, <[email protected]> wrote: >> >>> >>> Am Dienstag, 27. Mai 2014 22:31:37 UTC+2 schrieb Sam Berlin: >>> >>>> What do folks think of the idea? It'd make accepting patches easier >>>> (with pull requests, etc), and I'm sure there's other benefits for folks >>>> using the code too. >>>> >>>> >>> I have to ask why not to move to: >>> >>> https://guice-review.googlesource.com >>> >>> instead? >>> >>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "google-guice" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To post to this group, send email to [email protected]. >>> >>> Visit this group at http://groups.google.com/group/google-guice. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/google-guice. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "google-guice" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/google-guice. For more options, visit https://groups.google.com/d/optout.
