Agreed on all counts. Though we already have a process for CLA
management in google, though that's a good feature request to ask of the
github folks.
c.
On 28 May 2014, at 8:35, Sam Berlin wrote:
Guava follows a different process than Guice. I'd like to try and
encourage more community development here.
sam
On Wed, May 28, 2014 at 11:33 AM, Shawn Pearce <[email protected]> wrote:
On Wed, May 28, 2014 at 8:31 AM, Shawn Pearce <[email protected]> wrote:
On Wed, May 28, 2014 at 7:14 AM, Sam Berlin <[email protected]>
wrote:
Yeah, I see now. I have nothing against using gerrit for code
reviews
if folks want to do that
We are more than happy to host Guice on Gerrit at googlesource.com,
if
that is where you want to host.
One advantage over GitHub is Gerrit inherently knows about
contributor
license agreements, and can make sure those are completed before the
user
even uploads a change to you for review. Its also hosted by Google,
which
gives us control over its uptime. :)
But checking CLAs isn't an issue if you aren't going to take the
code.
... but overall, I think hosting the project itself on GitHub is the
best
option. GitHub just seems to have better community engagement
tools. We
generally do most development of Guice internally (with internal
code
reviews) anyway, since changes have to be tested over the whole
corpus.
For accepting occasional patches, GitHub just seems much easier...
folks
can easily fork, send a pull request, etc..
Not sure how much this really matters. Guice is mostly developed
internally at Google. Even there submitting patches from outside of
the
Guice team is... interesting. I remember spending a fairly long time
to
make a simple bug fix in one of the Future wrappers. The team has
very high
standards, which I really do enjoy as a consumer of the library. :)
Sorry, I haven't bootstrapped with caffeine yet this morning. I think
I
meant Guava above. I haven't contributed anything to Guice because I
have
been lucky enough to never find a bug. :)
--
You received this message because you are subscribed to the Google
Groups "google-guice" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice.
For more options, visit https://groups.google.com/d/optout.
Christian Gruber :: Google, Inc. :: Java Core Libraries :: Dependency
Injection
email: [email protected] :::: mobile: +1 (646) 807-9839
--
You received this message because you are subscribed to the Google Groups
"google-guice" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice.
For more options, visit https://groups.google.com/d/optout.
