Hi Stephan


(Sorry for the delay)


Our main concern with onami-persist is related to this:

"AOP synthetic warnings after Java 8 upgrade" - https://groups.google.com/

forum/#!topic/google-guice/-DH5fBD7M30


The "easy" patch seems the one pointed in the e-mail but, if I had 

understanded the PersistenceModule#configurePersistenceUnits method and 
bind a 

custom method matcher to exclude synthetic methods. Something like this 
(bolded text):


*private static final class TransactionMethodMatcher extends 
AbstractMatcher<Method> {*

* @Override*

* public boolean matches(final Method method) {*

* return method.isAnnotationPresent(Transactional.class) && 
!method.isSynthetic();*

* }*

* }*


/**

* Configures the persistence units.

*/

private void configurePersistenceUnits() {

this.configurePersistence();

this.bind(PersistenceFilter.class).to(PersistenceFilterImpl.class) 
.in(Scopes.SINGLETON);


final AllPersistenceUnits allPersistenceUnits = new AllPersistenceUnits();

this.requestInjection(allPersistenceUnits);

this.bind(AllPersistenceServices.class).toInstance(allPersistenceUnits);

this.bind(AllUnitsOfWork.class).toInstance(allPersistenceUnits);


for (final PersistenceUnitModuleConfiguration config : this.configurations) 
{

final TxnInterceptor txnInterceptor = new TxnInterceptor();


this.install(new PersistenceUnitModule(config, txnInterceptor, 
allPersistenceUnits));


*this.bindInterceptor(any(), new TransactionMethodMatcher(), *

*txnInterceptor);*

* this.bindInterceptor(annotatedWith(Transactional.class), new *

*TransactionMethodMatcher(), txnInterceptor);*

}

}


But this is a bit overkill because basically we are excluding all the 
synthetic methods - perhaps the best workaround should be able to give a 
class matcher to this method with the classes to exclude?


Regards
El martes, 25 de julio de 2017, 14:45:05 (UTC+2), scl escribió:
>
> Cool to see my code still is alive :) 
>
> My offer still stands. I can help anybody who wants to use it. 
> If it helps I can also migrate it to my github account so you have an 
> issue tracker and can create pull requests 
>
>
>
> On 25.07.2017 11:34, Asier wrote: 
> > Hi 
> > 
> > There's a fork of onami-persist, which has some enhacements. We are not 
> using 
> > it, but thinking about to migrate from onami-persist to 
> "tocktix"-persist. 
> > 
> > https://github.com/tocktix/onami-persist 
> > 
> > We miss an open-session-in-view library with support, but hey, your 
> library 
> > works very well for us and we don't have the knowledge to maintain it so 
> > thanks for releasing it. 
> > 
> > This is another matter, but lack of extensions make us think about 
> leaving 
> > Guice and start with Spring, as most projects are using it because of 
> its rich 
> > ecosystem. 
> > 
> > Regards 
> > 
> > El miércoles, 5 de abril de 2017 0:52:48 (CEST) Stephan Classen 
> escribió: 
> >> Hard to say 
> >> 
> >> I'm not working for Google but last time I asked this question it 
> >> remained unanswered. 
> >> Last real development I see in 2011. After this only whitespace 
> >> refactorings. 
> >> 
> >> The Issues in the issue tracker are also open since a very long time. 
> >> 
> >> Because of this I wrote my own persistence extension for guice. This 
> >> project has never attracted much attention and is by now also kind of 
> >> abandoned. If you decide to resurrect it, I will gladly give you a hand 
> >> src: https://svn.apache.org/viewvc/onami/trunk/persist/ 
> >> doc: https://onami.apache.org/persist/index.html 
> >> 
> >> On 05.04.2017 00:16, Serega Sheypak wrote: 
> >>> Hi, is it alive? I made it work, looks nice, but: 
> >>> 1. I need Finder stuff. Seems like warp is dead? 
> >>> 2. Will google-persist get new features? 
> > 
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"google-guice" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/google-guice.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-guice/eb0edb65-b2bf-47dd-95f1-40b1a4205b9d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to