I agree about the single focus - I wasn't suggesting diluting the purpose of the library - I was thinking more that those who have developed libraries based on guice-persist who may be wondering about being dependent on it, and possibly also willing to collaborate
On 12 September 2017 at 09:43, Stephan Classen <st.clas...@gmx.ch> wrote: > Maybe in a second phase. I would first concentrate on pulling the > different efforts for onami-persist together. But personally I prefer to > focus on one responsibility with such libraries. And I see the main > responsibility of onami-persist in providing JPA and JTA integration for > guice. > > > > On 12.09.2017 10:38, David Sowerby wrote: > > Seems like a good plan to me. Persistence isn't my strong suit, but I am > certainly happy to help, and contribute where I can. > > Do you think it is worth contacting people who have Guice integrations > with guice-persist, as that seems to be defunct? I'm thinking of projects > like this one <https://github.com/xvik/guice-persist-orient> > > On 12 September 2017 at 09:01, Stephan Classen <st.clas...@gmx.ch> wrote: > >> So a quick search on github finds 3 forks of onami-persist. >> >> https://github.com/tocktix/onami-persist >> https://github.com/FingolfinTEK/onami-persist >> https://github.com/davidsowerby/krail-jpa >> >> Is there interest in joining forces? If so I would suggest I start a new >> github organization for onami-persist and scratch together the history from >> my local repo (the apache SVN is not very helpfull, as all onami >> sub-projects shared a single SVN). >> As a next step we can bring in the existing additions/features/bugfixes >> from the different forks. >> >> Of course I will add all contributors to the organization. >> >> What do you think? >> >> >> On 10.09.2017 12:08, David Sowerby wrote: >> >> On the general topic of persistence for Guice - I did integrate >> onami-persist as a persistence component >> <https://github.com/davidsowerby/krail-jpa> for my own project >> <https://github.com/davidsowerby/krail> quite a while ago - there have >> been a few downloads, though I cannot claim it is a raging success! >> >> However, I am getting back to developing my work further and would not >> want to lose what seems to be the only Guice based persistence available - >> I would certainly like to see onami-persist kept alive if that's possible >> >> On Saturday, 9 September 2017 09:39:05 UTC+1, Asier wrote: >>> >>> Hi Stephan >>> >>> >>> (Sorry for the delay) >>> >>> >>> Our main concern with onami-persist is related to this: >>> >>> "AOP synthetic warnings after Java 8 upgrade" - >>> https://groups.google.com/ >>> >>> forum/#!topic/google-guice/-DH5fBD7M30 >>> >>> >>> The "easy" patch seems the one pointed in the e-mail but, if I had >>> >>> understanded the PersistenceModule#configurePersistenceUnits method and >>> bind a >>> >>> custom method matcher to exclude synthetic methods. Something like this >>> (bolded text): >>> >>> >>> *private static final class TransactionMethodMatcher extends >>> AbstractMatcher<Method> {* >>> >>> * @Override* >>> >>> * public boolean matches(final Method method) {* >>> >>> * return method.isAnnotationPresent(Transactional.class) && >>> !method.isSynthetic();* >>> >>> * }* >>> >>> * }* >>> >>> >>> /** >>> >>> * Configures the persistence units. >>> >>> */ >>> >>> private void configurePersistenceUnits() { >>> >>> this.configurePersistence(); >>> >>> this.bind(PersistenceFilter.class).to(PersistenceFilterImpl.class) >>> .in(Scopes.SINGLETON); >>> >>> >>> final AllPersistenceUnits allPersistenceUnits = new >>> AllPersistenceUnits(); >>> >>> this.requestInjection(allPersistenceUnits); >>> >>> this.bind(AllPersistenceServices.class).toInstance(allPersistenceUnits); >>> >>> this.bind(AllUnitsOfWork.class).toInstance(allPersistenceUnits); >>> >>> >>> for (final PersistenceUnitModuleConfiguration config : >>> this.configurations) { >>> >>> final TxnInterceptor txnInterceptor = new TxnInterceptor(); >>> >>> >>> this.install(new PersistenceUnitModule(config, txnInterceptor, >>> allPersistenceUnits)); >>> >>> >>> *this.bindInterceptor(any(), new TransactionMethodMatcher(), * >>> >>> *txnInterceptor);* >>> >>> * this.bindInterceptor(annotatedWith(Transactional.class), new * >>> >>> *TransactionMethodMatcher(), txnInterceptor);* >>> >>> } >>> >>> } >>> >>> >>> But this is a bit overkill because basically we are excluding all the >>> synthetic methods - perhaps the best workaround should be able to give a >>> class matcher to this method with the classes to exclude? >>> >>> >>> Regards >>> El martes, 25 de julio de 2017, 14:45:05 (UTC+2), scl escribió: >>>> >>>> Cool to see my code still is alive :) >>>> >>>> My offer still stands. I can help anybody who wants to use it. >>>> If it helps I can also migrate it to my github account so you have an >>>> issue tracker and can create pull requests >>>> >>>> >>>> >>>> On 25.07.2017 11:34, Asier wrote: >>>> > Hi >>>> > >>>> > There's a fork of onami-persist, which has some enhacements. We are >>>> not using >>>> > it, but thinking about to migrate from onami-persist to >>>> "tocktix"-persist. >>>> > >>>> > https://github.com/tocktix/onami-persist >>>> > >>>> > We miss an open-session-in-view library with support, but hey, your >>>> library >>>> > works very well for us and we don't have the knowledge to maintain it >>>> so >>>> > thanks for releasing it. >>>> > >>>> > This is another matter, but lack of extensions make us think about >>>> leaving >>>> > Guice and start with Spring, as most projects are using it because of >>>> its rich >>>> > ecosystem. >>>> > >>>> > Regards >>>> > >>>> > El miércoles, 5 de abril de 2017 0:52:48 (CEST) Stephan Classen >>>> escribió: >>>> >> Hard to say >>>> >> >>>> >> I'm not working for Google but last time I asked this question it >>>> >> remained unanswered. >>>> >> Last real development I see in 2011. After this only whitespace >>>> >> refactorings. >>>> >> >>>> >> The Issues in the issue tracker are also open since a very long >>>> time. >>>> >> >>>> >> Because of this I wrote my own persistence extension for guice. This >>>> >> project has never attracted much attention and is by now also kind >>>> of >>>> >> abandoned. If you decide to resurrect it, I will gladly give you a >>>> hand >>>> >> src: https://svn.apache.org/viewvc/onami/trunk/persist/ >>>> >> doc: https://onami.apache.org/persist/index.html >>>> >> >>>> >> On 05.04.2017 00:16, Serega Sheypak wrote: >>>> >>> Hi, is it alive? I made it work, looks nice, but: >>>> >>> 1. I need Finder stuff. Seems like warp is dead? >>>> >>> 2. Will google-persist get new features? >>>> > >>>> >>>> -- >> You received this message because you are subscribed to the Google Groups >> "google-guice" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to google-guice+unsubscr...@googlegroups.com. >> To post to this group, send email to google-guice@googlegroups.com. >> Visit this group at https://groups.google.com/group/google-guice. >> To view this discussion on the web visit https://groups.google.com/d/ms >> gid/google-guice/be528d8d-9ab0-4127-9bbe-ec39b3546200%40googlegroups.com >> <https://groups.google.com/d/msgid/google-guice/be528d8d-9ab0-4127-9bbe-ec39b3546200%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> >> >> > > > -- > regards > > David > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to google-guice+unsubscr...@googlegroups.com. > To post to this group, send email to google-guice@googlegroups.com. > Visit this group at https://groups.google.com/group/google-guice. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/google-guice/CA%2Bh17MP_Ta8qQBhevCbjDk%2B_2EBwe1oQ%3D% > 3D__YM-Oz3RYOCVm%3Dg%40mail.gmail.com > <https://groups.google.com/d/msgid/google-guice/CA%2Bh17MP_Ta8qQBhevCbjDk%2B_2EBwe1oQ%3D%3D__YM-Oz3RYOCVm%3Dg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > > > -- regards David -- You received this message because you are subscribed to the Google Groups "google-guice" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-guice+unsubscr...@googlegroups.com. To post to this group, send email to google-guice@googlegroups.com. Visit this group at https://groups.google.com/group/google-guice. To view this discussion on the web visit https://groups.google.com/d/msgid/google-guice/CA%2Bh17MMcdy2JAfVeiCQvRMjmbOtp84414gOQ3id%2BG2zRkitggw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
