Well done. Really appriciated, for both Flash and Flex ports :-) However, you can make it more Flash-ish or Flex-ish. Here are few points.
(1) ClusterMarker.initialise(map:Map) should be removed. As you can see, this method seems to do 2 things. (a) set map, so that we will later use it to convert between latlng and point, and (b) give initial value of x and y. I see both unnecessary, because (a) as I am a perfectionist, I do not think Overlay should directly relate to Map but Pane. Pane also have methods to do latlng-point conversion. To be extreme, getDefaultPane() should not be override. At the point of ClusterMarker being used, Cluster.redraw_, it can be added into a specific pane, rather than a map. (b) it is recommended to initialize display-purpose variables in 'OVERLAY_ADDED' listener. There are more reasons to use 'OVERLAY_ADDED' listener, as you read on. (2) the current ClusterMarker should be renamed as ClusterMarkerBase. (2.1) That allows other developer to customize the visual of marker. In this implementation of ClusterMarker, the visual display has been fixed as images - which inherits the coolest implementation from JavaScript version. I actually want to fancy it with some animations. After all, ClusterMarker is yet another marker, the marker-clustermaker relationship is maintained in Cluster. (2.2) There will be another class, so-called ImageClusterMarker, extending ClusterMarkerBase, to load clustermarker images on demand, which will be done in OVERLAY_ADDED listener. By the way, the most portion in current ClusterMarker's construction should be moved into 'OVERLAY_ADDED' listener; and 'OVERLAY_REMOVED' listener is also needed to remove and nullize the children, for performance reason. Can we make a google code project (,give it a nice name) and share code and more contribution will come? I also have some code to share, such as custom overlays. Juguang On Wed, Jul 8, 2009 at 12:20 AM, I_Watkins <[email protected]> wrote: > > OK, now got this working in Flex. > > Download a project archive from: > > http://groups.google.com/group/google-maps-api-for-flash/web/ForFlex_MarkerClusterDemo.zip > > Uses the excellent work Sean did getting it ported to Flash and is of > course based on Xiaoxi Wu's original JavaScript code. > > I'm not super hot on modifying other peoples code, or with custom > components, but this works for me and if anybody feels like tidying it > all up, do feel free :-) > > Cheers > > Ian > > > -- ============= Juguang XIAO Beijing, China --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Google Maps API For Flash" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/google-maps-api-for-flash?hl=en -~----------~----~----~----~------~----~------~--~---
