Thanks Pamela, I just check in my code into project svn repo.
I agree with you on letting people check out the source code by themselves. You cannot keep up recompiling SWC each time when the monkey people like me keep rewriting and patching code at the middle of night. :-) And it should be encouraged that people download the source and look at it in hope to inspire better ideas. For developers who have not managed to use svn (successfully), try it out (again). There is a old Chinese saying, "it is more preferred to give (teach) people fishing (skills) over to give a fish" If you have problem on svn, let us know. We will teach you fishing (using svn) to get fish (source, no longer swc). :-) Juguang On Tue, Jul 14, 2009 at 8:07 AM, pamela (Google Employee) < [email protected]> wrote: > Hi Jugang- > > I've added you to the project. > > Right now, all the code is in one namespace/project, and I re-compile a SWC > each time a library is added. I think perhaps this might not be necessary - > as I don't think most developers are using all the libraries at once - and > it's a fair amount of work for me. > > It might be better if I deprecate the SWC and always recommend that people > checkout the code and include it in their project. I'd be curious for your > opinion. > > - pamela > > > On Mon, Jul 13, 2009 at 5:30 PM, Juguang XIAO <[email protected]> wrote: > >> Attached is the refactored code, in com.google.maps.extras.markerclusterer >> package. Few changes: >> >> 1. change package name >> 2. add 2 classes: MarkerClustererOptions (in use) and MarkerStyleOptions >> (currently not in use) >> 3. rename 2 classes: ClusterMarker_ to ClusterMarker; Marker_ to >> UnitMarker >> 4. change type Number to int, where necessary - such as index and length ( >> for performance sake) >> 5. change public function to private, where necessary (for better OOP) >> 6. use of MarkerClusterOptions to replace individual variables for >> maxZoom, gridSize and styles, in MarkerClusterer >> 7. remove map-related code in Cluster and ClusterMarker; use Pane-based >> solution. This has been done partially. More to be done later. >> 8. replace index-iteration loop with item-iteration. (most Flash-ish) >> 9. use strong type in ActionScript 3, rather than weak type in JavaScript. >> >> And there are more to-dos: >> >> 1. make Pane-based solution complete. >> 2. add docs for class and functions. >> 3. create ClusterMarkerBase class and its subclass for loading image >> markers >> 4. unifying Flash and Flex code into one. As the matter of basic fact, the >> really difference is currently very thin, on which package to use. The >> solution may be even simpler, using neither fl.* nor mx.*, but >> flash.display.* package. :-) >> 5. you name it. >> >> >> I have signed digital CLA. what should I do next? >> >> Another question is, I want to check in my code in svn, rather than >> compile into swc. Can i do that in *gmaps-utility-library-flash project? >> * >> >> Cheers, >> Juguang >> >> >> >> On Wed, Jul 8, 2009 at 8:29 AM, pamela (Google Employee) < >> [email protected]> wrote: >> >>> >>> Hey folks- >>> >>> I have a project that collects various extensions together, I'd be >>> happy to have it there: >>> http://gmaps-utility-library-flash.googlecode.com/ >>> >>> To add you to the project, I just need you to sign the digital CLA and >>> let me know when you've done so: >>> http://code.google.com/legal/individual-cla-v1.0.html (scroll down for >>> an easy form) >>> >>> - pamela >>> >>> On Wed, Jul 8, 2009 at 10:26 AM, Juguang XIAO<[email protected]> wrote: >>> > Well done. Really appriciated, for both Flash and Flex ports :-) >>> > >>> > However, you can make it more Flash-ish or Flex-ish. Here are few >>> points. >>> > >>> > (1) ClusterMarker.initialise(map:Map) should be removed. As you can >>> see, >>> > this method seems to do 2 things. (a) set map, so that we will later >>> use it >>> > to convert between latlng and point, and (b) give initial value of x >>> and y. >>> > I see both unnecessary, because (a) as I am a perfectionist, I do not >>> think >>> > Overlay should directly relate to Map but Pane. Pane also have methods >>> to do >>> > latlng-point conversion. To be extreme, getDefaultPane() should not be >>> > override. At the point of ClusterMarker being used, Cluster.redraw_, it >>> can >>> > be added into a specific pane, rather than a map. (b) it is recommended >>> > to initialize display-purpose variables in 'OVERLAY_ADDED' >>> listener. There >>> > are more reasons to use 'OVERLAY_ADDED' listener, as you read on. >>> > >>> > (2) the current ClusterMarker should be renamed as ClusterMarkerBase. >>> > >>> > (2.1) That allows other developer to customize the visual of marker. In >>> this >>> > implementation of ClusterMarker, the visual display has been fixed as >>> images >>> > - which inherits the coolest implementation from JavaScript version. I >>> > actually want to fancy it with some animations. After all, >>> ClusterMarker is >>> > yet another marker, the marker-clustermaker relationship is maintained >>> in >>> > Cluster. >>> > >>> > (2.2) There will be another class, so-called ImageClusterMarker, >>> extending >>> > ClusterMarkerBase, to load clustermarker images on demand, which will >>> be >>> > done in OVERLAY_ADDED listener. By the way, the most portion in current >>> > ClusterMarker's construction should be moved into 'OVERLAY_ADDED' >>> listener; >>> > and 'OVERLAY_REMOVED' listener is also needed to remove and nullize the >>> > children, for performance reason. >>> > >>> > Can we make a google code project (,give it a nice name) and share code >>> and >>> > more contribution will come? I also have some code to share, such as >>> custom >>> > overlays. >>> > >>> > Juguang >>> > >>> > >>> > On Wed, Jul 8, 2009 at 12:20 AM, I_Watkins <[email protected]> >>> wrote: >>> >> >>> >> OK, now got this working in Flex. >>> >> >>> >> Download a project archive from: >>> >> >>> >> >>> http://groups.google.com/group/google-maps-api-for-flash/web/ForFlex_MarkerClusterDemo.zip >>> >> >>> >> Uses the excellent work Sean did getting it ported to Flash and is of >>> >> course based on Xiaoxi Wu's original JavaScript code. >>> >> >>> >> I'm not super hot on modifying other peoples code, or with custom >>> >> components, but this works for me and if anybody feels like tidying it >>> >> all up, do feel free :-) >>> >> >>> >> Cheers >>> >> >>> >> Ian >>> >> >>> >> -- >>> >> ============= >>> >> Juguang XIAO >>> >> Beijing, China >>> >> >>> >> >>> >> >> >>> > >>> >>> >>> >> >> >> -- >> ============= >> Juguang XIAO >> Beijing, China >> >> >> >> > > > > -- ============= Juguang XIAO Beijing, China --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Google Maps API For Flash" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/google-maps-api-for-flash?hl=en -~----------~----~----~----~------~----~------~--~---
