On Mon, Sep 15, 2008 at 10:35 AM, Joel Webber <[EMAIL PROTECTED]> wrote:
> The compiler does a fine job inlining the whole mess of strings together > (the compiled code looks something like (str0 + arg0 + str1)). > Cool! > > This code is also all covered by the tests in ImageTest, which test clipped > images pretty thoroughly. I also verified them visually on affected > browsers. > LGTM. > > > On Mon, Sep 15, 2008 at 10:19 AM, Emily Crutcher <[EMAIL PROTECTED]> wrote: > >> Is the compiler able to factor the entire "<img..." string as a static >> string, minus the style string of course? If not, should we make the private >> static that full impl prefix instead of just the CLEAR_GIF? >> >> Can you describe the testing to validate this change? >> >> >> On Mon, Sep 15, 2008 at 9:46 AM, Joel Webber <[EMAIL PROTECTED]> wrote: >> >>> Emily, >>> I'd like you to have a look at this patch for issue 2884. It gets rid of >>> an extra HTTP request in the default clipped-image implementation using a >>> data: url (see the issue for details). >>> >>> Issue: 2884 >>> Patch by: jgw >>> Review by: ecc >>> Affected Files: >>> M user/src/com/google/gwt/user/ClippedImage.gwt.xml >>> A >>> user/src/com/google/gwt/user/client/ui/impl/DataUrlClippedImageImpl.java >>> >>> Thanks, >>> joel. >>> >> >> >> >> -- >> "There are only 10 types of people in the world: Those who understand >> binary, and those who don't" >> > > -- "There are only 10 types of people in the world: Those who understand binary, and those who don't" --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
