+1. I was looking for modal/autoHide accessors recently as well. At the time, I didn't see any reason they could/should not be implemented in PopupPanel.
On Mon, Oct 6, 2008 at 11:54 AM, Jason Essington <[EMAIL PROTECTED]>wrote: > +1 here, as I've recently had to use the violator pattern to flip those > bits. > -jason > > On Oct 6, 2008, at 9:44 AM, John LaBanca wrote: > > Contributors - > > I propose adding the following accessors and getters to PopupPanel: > public boolean isAutoHideEnabled() > public boolean isModal() > public void setAutoHideEnabled(boolean autoHide) > public void setModal(boolean modal) > > Currently, autoHide and modal are private members of PopupPanel, so > subclasses cannot change these values. From a cursory glance, it looks like > PopupPanel checks these variables as needed, so implementing these methods > would not require any special handling in case the PopupPanel is currently > open. > > Here is the relevant issue: > http://code.google.com/p/google-web-toolkit/issues/detail?id=2855 > > This seems like a valuable addition to the API, but I wanted to see if > anyone has an obvious reason why we shouldn't add these methods. > > Thanks, > John LaBanca > [EMAIL PROTECTED] > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
