Hey Alex, Thanks for putting this fix together. Comments below:
DialogBox.java 199: Spelling: sceen --> screen 243: @Overrides on an a method that implements an interface only works in Java 1.6. While GWT on the the trunk currently support JDK 1.6, the code base still compiles under GWT 1.5. If this change goes in, then GWT will no longer be able to compile under JDK 1.5. Let's get rid of the annotation. 245: Do you need to recompute clientLeft and clientTop on window resize? Can these change based on a window resize? General: I did some testing and it looks good. Dragging in IE6 in RTL mode is still somewhat odd with the jumpiness, but workable. I wonder if we could improve RTL dragging in general in IE6/IE7. It might be worth filing a bug for. If I had to suspect something, it might be the use of CSS expressions and a hidden IFRAME to prevent scrollbar shine-through. This isn't needed in IE7, as they've fixed this at the rendering level, so it might be worth exploring at least an improvement for IE7 at some point. After addressing the above nits, feel free to hit the commit switch. Rajeev On Mon, Oct 6, 2008 at 4:03 PM, Alex Rudnick <[EMAIL PROTECTED]> wrote: > Hey Rajeev :) > > Would you take a look at this patch, implementing Joel's suggestion > for keeping DialogBox on the screen? > > Instead of trying to decide whether a PopupPanel is being positioned > off the edge, we check whether the user is dragging it off the screen, > and ignore the drag if the pointer has left the visible window area. > We use a WindowResizeListener to make sure we always know how wide the > window is. > > Also, in the PopupPanel class, we remove the check that prevents > placing a popup offscreen -- if a developer wants to programmatically > put it off screen, that's OK. > > > Seems to work right in RTL and LTR modes on all major browsers. > > Thanks! > > -- > Alex Rudnick > swe, gwt, atl > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
