Hey Rajeev :) Thanks for the quick review!
Responses inline. On Mon, Oct 6, 2008 at 7:08 PM, Rajeev Dayal <[EMAIL PROTECTED]> wrote: > DialogBox.java > 199: Spelling: sceen --> screen OK > 243: @Overrides on an a method that implements an interface only works in > Java 1.6. While GWT on the the trunk currently support JDK 1.6, the code > base still compiles under GWT 1.5. If this change goes in, then GWT will no > longer be able to compile under JDK 1.5. Let's get rid of the annotation. OK > 245: Do you need to recompute clientLeft and clientTop on window resize? Can > these change based on a window resize? I don't think they can change on resize. For example, in RTL mode for IE, clientLeft is the width of a scrollbar. > General: > I did some testing and it looks good. Dragging in IE6 in RTL mode is still > somewhat odd with the jumpiness, but workable. I wonder if we could improve > RTL dragging in general in IE6/IE7. It might be worth filing a bug for. If I > had to suspect something, it might be the use of CSS expressions and a > hidden IFRAME to prevent scrollbar shine-through. This isn't needed in IE7, > as they've fixed this at the rendering level, so it might be worth exploring > at least an improvement for IE7 at some point. > After addressing the above nits, feel free to hit the commit switch. Committed r3724, put in issue 2957. -- Alex Rudnick swe, gwt, atl --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
