[google-web-toolkit] [EMAIL PROTECTED] commented on branch /branches/1_6_clean_events. Details are at http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083&branch=%2Fbranches%2F1_6_clean_events
General Comment: DefaultHandlerRegistration: http://code.google.com/p/google-web-toolkit/source/browse/branches/1_6_clean_events/user/src/com/google/gwt/event/shared/DefaultHandlerRegistration.java?spec=issue3083&r=3987 Line-by-line comments: File: /branches/1_6_clean_events/user/src/com/google/gwt/event/shared/DefaultHandlerRegistration.java (r3987) =============================================================================== Line 23: public class DefaultHandlerRegistration implements HandlerRegistration { ------------------------------------------------------------------------------- I outlined an evil plan to make this a nested class of HandlerManager. The comment is in HandlerManager feedback. I don't know if it's possible but it seemed like it was worth considering. Line 25: private HandlerManager manager; ------------------------------------------------------------------------------- These can all be final. Respond to these comments at http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083&branch=%2Fbranches%2F1_6_clean_events -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
